fix(schema): avoid creating unnecessary clone of schematype in nested array so nested document arrays use correct constructor #14128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14101
Summary
The underlying issue in #14101 is that we have two different schema types for
options
andoptions.$
, even though they should be the same. Which leads to issues when validating a subdoc ofoptions.$
's caster usingoptions
schematype. Specifically triggering thisif
statement, which leads to issues with nested arrays becausescope
can be an array.The fix is to avoid cloning, so
options
andoptions.$
are largely interchangeable as far as casting and validation are concerned.Examples