Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(connections): add example of registering connection event handlers #14150

Merged
merged 3 commits into from Dec 4, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13879

Summary

Added a code sample of how to register connection event handlers to Connection Events section. Also removed the fullsetup and all events, because those are no longer emitted. Mongoose used to bubble those up from the MongoDB Node.js driver, but those were removed a long time ago.

Examples

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, maybe consider using inline-code-blocks for the events instead of single-quotes.
also added a unrelated question that i am curious about

docs/connections.md Outdated Show resolved Hide resolved
docs/connections.md Outdated Show resolved Hide resolved
docs/connections.md Show resolved Hide resolved
@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Dec 4, 2023
vkarpov15 and others added 2 commits December 4, 2023 11:54
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 vkarpov15 merged commit 62b3f45 into master Dec 4, 2023
2 checks passed
@vkarpov15 vkarpov15 added this to the 8.0.3 milestone Dec 4, 2023
@hasezoey hasezoey deleted the vkarpov15/gh-13879 branch December 4, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] code example for connection event handlers
2 participants