fix(populate): handle deselecting _id
with array of fields in populate()
#14242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14231
Summary
We handle deselecting
_id
inpopulate()
using the following syntax:await U.findOne({ name: 'u1' }).populate('comments', '-_id');
but putting-_id
in an arrayawait U.findOne({ name: 'u1' }).populate('comments', ['-_id']);
leads to a malformed result document wherecomments
is[ { '0': '-_id' } ]
due to how we shallow copy select conditions before removing_id
. So we need an additional case to avoid using{ ... }
to shallow copy an array.Examples