Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition for Connection.prototype.createCollections() not in connections.d.ts #14279

Closed
2 tasks done
Brendmanitix opened this issue Jan 21, 2024 · 0 comments · Fixed by #14295
Closed
2 tasks done
Labels
typescript Types or Types-test related issue / Pull Request
Milestone

Comments

@Brendmanitix
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Mongoose version

8.1.0

Node.js version

n/a

MongoDB server version

n/a

Typescript version (if applicable)

5.x

Description

[Connection.prototype.createCollections()] (https://mongoosejs.com/docs/api/connection.html#Connection.prototype.createCollections()), isn't visible to Typescript. The definition wasn't added to connection.d.ts in the PR for the feature: #13324.

Steps to Reproduce

Install latest version of mongoose (8.1.0), see that the connection.createCollections isn't in the type definition.
image
Confirm by visiting the source code: https://github.com/Automattic/mongoose/blob/master/types/connection.d.ts

Expected Behavior

No response

@vkarpov15 vkarpov15 added this to the 8.1.1 milestone Jan 22, 2024
@vkarpov15 vkarpov15 added the typescript Types or Types-test related issue / Pull Request label Jan 22, 2024
@vkarpov15 vkarpov15 modified the milestones: 8.1.1, 8.1.2 Jan 23, 2024
vkarpov15 added a commit that referenced this issue Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants