Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(model): correct return type for findOneAndUpdate with includeResultMetadata and lean set #14336

Merged
merged 1 commit into from Feb 7, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14303

Summary

Quick fix for correct return type when calling findOneAndUpdate() with includeResultMetadata: true and lean: true: return a ModifyResult with the lean doc type.

Examples

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Feb 7, 2024
@vkarpov15 vkarpov15 added this to the 8.1.2 milestone Feb 7, 2024
@vkarpov15 vkarpov15 merged commit 870b94f into master Feb 7, 2024
5 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14303 branch February 7, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

includeResultMetadata types not changing return type?
2 participants