feat(query): add options
parameter to Query.prototype.sort()
#14375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14365
Summary
Right now,
sort(null)
is a no-op. There's no good way to unset the current sort option other thandelete query.getOptions().sort
, which works but looks a bit janky. This PR addsq.sort(null, { override: true })
, theoverride
option lets you explicitly override the current sort.Examples