Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function SchemaType.prototype.validateAll #14434

Merged
merged 5 commits into from Mar 18, 2024
Merged

Add function SchemaType.prototype.validateAll #14434

merged 5 commits into from Mar 18, 2024

Conversation

IslandRhythms
Copy link
Collaborator

closes #6910

@IslandRhythms IslandRhythms self-assigned this Mar 13, 2024
@hasezoey hasezoey changed the title Island rhythms/gh 6910 Add function SchemaType.prototype.validateAll Mar 14, 2024
@hasezoey hasezoey added the new feature This change adds new functionality, like a new method or class label Mar 14, 2024
hasezoey
hasezoey reviewed Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would like to see some JSDoc and Typescript types.
Also some minor style nitpicks.

PS: changed the title to better reflect what this issue is about

lib/schemaType.js Outdated Show resolved Hide resolved
test/schematype.test.js Outdated Show resolved Hide resolved
test/schematype.test.js Outdated Show resolved Hide resolved
vkarpov15 and others added 2 commits March 14, 2024 14:41
@vkarpov15 vkarpov15 requested a review from hasezoey March 14, 2024 18:42
@vkarpov15 vkarpov15 added this to the 8.3 milestone Mar 18, 2024
@vkarpov15 vkarpov15 changed the base branch from master to 8.3 March 18, 2024 20:25
@vkarpov15 vkarpov15 merged commit dc9810b into 8.3 Mar 18, 2024
23 checks passed
@vkarpov15 vkarpov15 deleted the IslandRhythms/gh-6910 branch March 18, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@hasezoey hasezoey hasezoey approved these changes

Assignees

@IslandRhythms IslandRhythms

Labels
new feature This change adds new functionality, like a new method or class
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.

Add validateMany feature method
3 participants
@IslandRhythms @vkarpov15 @hasezoey