Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): deduplicate idGetter so creating multiple models with same schema doesn't result in multiple id getters #14492

Merged
merged 1 commit into from Apr 4, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14457

Summary

Need to be careful to avoid adding multiple id getters when reusing the same schema multiple times

Examples

…me schema doesn't result in multiple id getters

Fix #14457
@vkarpov15 vkarpov15 added this to the 7.6.11 milestone Apr 2, 2024
@vkarpov15 vkarpov15 merged commit 131d13c into master Apr 4, 2024
38 checks passed
@vkarpov15 vkarpov15 modified the milestones: 7.6.11, 8.2.5 Apr 4, 2024
@hasezoey hasezoey deleted the vkarpov15/gh-14457 branch April 5, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getters array in virtualtype for "id" virtual is not deduped
2 participants