types(models): fix incorrect bulk write options #14513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
bulkWrite
options are incorrectly typed.timestamp
does not exists as an option onupdateOne
/updateMany
(there was a test but it didn't work, I fixed this as well). And the type incorrectly showed a timestamp as options tobulkWrite
, which doesn't work.Also extended the mongodb
BulkWriteOptions
making it easier to use theMongooseBulkWriteOption
without the need to also always extend mongodb.Examples
See fixed test