Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hydrate() recursively hydrate virtual populate docs if hydratedPopulatedDocs is set #14533

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Make hydrate() recursively hydrate virtual populate docs if hydratedPopulatedDocs is set #14533

merged 2 commits into from
Apr 24, 2024

Conversation

vkarpov15
Copy link
Collaborator

Summary

In #14503, the issue is that hydrate() sets the populated docs in the populated virtual, but doesn't hydrate them. The docs are still lean. This PR makes hydrate() hydrate those populated docs if hydratedPopulatedDocs is set.

Examples

@vkarpov15 vkarpov15 mentioned this pull request Apr 23, 2024
Closed
2 tasks
@vkarpov15 vkarpov15 added this to the 8.3.3 milestone Apr 24, 2024
@vkarpov15 vkarpov15 merged commit e91fcf4 into master Apr 24, 2024
34 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14503 branch April 24, 2024 20:39
@Gabo-Tech Gabo-Tech mentioned this pull request May 20, 2024
Open
@lholmquist lholmquist mentioned this pull request May 20, 2024
Closed
@James220903 James220903 mentioned this pull request May 20, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 20, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 20, 2024
Open
@tomlebl tomlebl mentioned this pull request May 21, 2024
Closed
@carltrepanier carltrepanier mentioned this pull request May 21, 2024
Merged
@OOCAZ OOCAZ mentioned this pull request May 21, 2024
Merged
@lonewolf0708 lonewolf0708 mentioned this pull request May 21, 2024
Open
This was referenced May 21, 2024
Merged
Merged
This was referenced May 21, 2024
Merged
Merged
@MihikaNigam MihikaNigam mentioned this pull request May 21, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 21, 2024
Open
@adriaaaann adriaaaann mentioned this pull request May 21, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 21, 2024
Open
This was referenced May 21, 2024
Merged
Merged
@tuanicom tuanicom mentioned this pull request May 21, 2024
Merged
@Proushoth Proushoth mentioned this pull request May 21, 2024
Open
@tomlebl tomlebl mentioned this pull request May 31, 2024
Closed
@Gabo-Tech Gabo-Tech mentioned this pull request Jun 1, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 2, 2024
Open
This was referenced Jun 2, 2024
Open
Open
Open
Open
@MohamedEl-naagar MohamedEl-naagar mentioned this pull request Jun 2, 2024
Open
This was referenced Jun 3, 2024
Open
Open
Open
Open
@asifurrahmanpial asifurrahmanpial mentioned this pull request Jun 3, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 4, 2024
Open
@trevormil trevormil mentioned this pull request Jun 4, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 4, 2024
Open
This was referenced Jun 4, 2024
Open
Open
@LiveGobe LiveGobe mentioned this pull request Jun 4, 2024
Open
@axqqt axqqt mentioned this pull request Jun 4, 2024
Open
@Kuldar9 Kuldar9 mentioned this pull request Jun 5, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jun 5, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jun 5, 2024
Open
@lholmquist lholmquist mentioned this pull request Jun 5, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 5, 2024
Open
@tomlebl tomlebl mentioned this pull request Jun 5, 2024
Closed
This was referenced Jun 5, 2024
Open
Open
Open
@nejidevelops nejidevelops mentioned this pull request Jun 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.3.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vkarpov15 @hasezoey