Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Automatically call translateAlias for queries. #7511

Closed
chrischen opened this issue Feb 11, 2019 · 3 comments
Closed

Feature: Automatically call translateAlias for queries. #7511

chrischen opened this issue Feb 11, 2019 · 3 comments
Labels
enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Milestone
7.2.0

Comments

@chrischen
Copy link

FEATURE

I plan on implementing this at some point, but would like to propose my method for doing this for some feedback.

I propose an option when defining the schema to indicate if the schema has aliased keys. If so, translateAliases can be called automatically when doing queries on the model.

If not, then the translateAliases call can be skipped entirely, so it avoids traversing the schema if the user is not using aliases.
@vkarpov15
Copy link
Collaborator

That's a good idea. We'll do this in a future release

@vkarpov15 vkarpov15 added this to the 5.x Unprioritized milestone Feb 12, 2019
@vkarpov15 vkarpov15 added the enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature label Feb 12, 2019
@baileytincher
Copy link

Has this been done or is someone working on it? I am interested in the feature and if nobody has it on their todo I could give it a shot.

@vkarpov15
Copy link
Collaborator

@baileytincher it has not been done and I am not aware of anyone working on this. Feel free to work on it and put in a PR against master 👍

@vkarpov15 vkarpov15 modified the milestones: 7.x Unprioritized, 7.2.0 Apr 6, 2023
vkarpov15 added a commit that referenced this issue May 13, 2023
@vkarpov15
feat(query): add translateAliases option to automatically call tran…
13bf560 
…slate aliases on query fields

Fix #7511
Fix #8678
@vkarpov15 vkarpov15 mentioned this issue May 13, 2023
Merged
vkarpov15 added a commit that referenced this issue May 15, 2023
@vkarpov15
Merge pull request #13397 from Automattic/vkarpov15/gh-7511
ca84162 
feat(query): add `translateAliases` option to automatically call translate aliases on query fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Projects
None yet
Milestone
7.2.0
Development

No branches or pull requests
3 participants
@chrischen @vkarpov15 @baileytincher