Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Node 21 Prebuilds #2295

Closed
dan-mcdonald opened this issue Oct 19, 2023 · 11 comments
Closed

Generate Node 21 Prebuilds #2295

dan-mcdonald opened this issue Oct 19, 2023 · 11 comments

Comments

@dan-mcdonald
Copy link

Node 21 was released a couple days ago.

$ npm install
...
npm ERR! node-pre-gyp http GET https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v120-linux-glibc-x64.tar.gz
npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v120-linux-glibc-x64.tar.gz 
npm ERR! node-pre-gyp WARN Pre-built binaries not installable for canvas@2.11.2 and node@21.0.0 (node-v120 ABI, glibc) (falling back to source compile with node-gyp) 
...
@KaiSchwarz-cnic
Copy link

npm ERR! code 1
npm ERR! path /usr/share/<project>/node_modules/canvas
npm ERR! command failed
npm ERR! command sh -c node-pre-gyp install --fallback-to-build --update-binary
npm ERR! Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --update-binary --module=/usr/share/<project>/node_modules/canvas/build/Release/canvas.node --module_name=canvas --module_path=/usr/share/<project>/node_modules/canvas/build/Release --napi_version=9 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v120' (1)

@ZsoltiHUB
Copy link

npm ERR! code 1 npm ERR! path /home/ubuntu/Discord-MusicBot/djs-bot/node_modules/canvas npm ERR! command failed npm ERR! command sh -c node-pre-gyp install --fallback-to-build --update-binary npm ERR! Failed to execute '/usr/bin/node /usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --update-binary --module=/home/ubuntu/Discord-MusicBot/djs-bot/node_modules/canvas/build/Release/canvas.node --module_name=canvas --module_path=/home/ubuntu/Discord-MusicBot/djs-bot/node_modules/canvas/build/Release --napi_version=9 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v120' (1) npm ERR! node-pre-gyp info it worked if it ends with ok npm ERR! node-pre-gyp info using node-pre-gyp@1.0.11 npm ERR! node-pre-gyp info using node@21.0.0 | linux | x64 npm ERR! (node:33170) [DEP0040] DeprecationWarning: The punycodemodule is deprecated. Please use a userland alternative instead. npm ERR! (Usenode --trace-deprecation ... to show where the warning was created) npm ERR! node-pre-gyp http GET https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v120-linux-glibc-x64.tar.gz npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v120-linux-glibc-x64.tar.gz npm ERR! node-pre-gyp WARN Pre-built binaries not installable for canvas@2.11.2 and node@21.0.0 (node-v120 ABI, glibc) (falling back to source compile with node-gyp) npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v120-linux-glibc-x64.tar.gz

@shdow-monarch
Copy link

Any solution for this issue ? I am also facing this issue.

schuerg added a commit to schuerg/node-canvas that referenced this issue Oct 27, 2023
@schuerg
Copy link

schuerg commented Oct 27, 2023

I would like to switch to Node.js 21 in a project because of memory leaks in older node versions in combination with jest tests. jestjs/jest#11956

Is it possible to add prebuilds even if node 21 is no lts version? I see in the git history, that other non-lts node versions also were supported.

Here is a PR: #2298

@zbjornson
Copy link
Collaborator

Prebuilds are up for MacOS and Linux. Windows failed and needs some work to investigate it. 😩

@schuerg
Copy link

schuerg commented Oct 27, 2023

Prebuilds are up for MacOS and Linux. Windows failed and needs some work to investigate it. 😩

Thanks!

Also thank you a lot for maintaining this library in general!

@olivierbelzile
Copy link

Any update on Windows prebuilds?

@ridays2001
Copy link

Is anyone facing issues while building this on Windows with node 21? I am unable to even build the package.

@luanon404
Copy link

Still waiting for node 21🫠🫠

@jmynes
Copy link

jmynes commented Dec 28, 2023

Any changes coming for this?

@zbjornson
Copy link
Collaborator

Prebuilds for Windows, Node.js v21, node-canvas v2.11.2 are up. The build was failing because of a regression in Node.js: nodejs/node#48673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants