Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support PhpStorm installed from JetBrains Toolbox app #21

Open
sc0ttkclark opened this issue Apr 24, 2024 · 0 comments
Labels
[Type] Enhancement Improvement upon an existing feature

Comments

@sc0ttkclark
Copy link

What

Currently the PhpStorm app when installed by JetBrains Toolbox does not get set to installed via the logic in https://github.com/Automattic/studio/blob/trunk/src/hooks/use-check-installed-apps.tsx

Why

JetBrains Toolbox does not keep the PhpStorm app in the /Applications/ folder, it's actually stored in the user's directory like for mine that may be something like /Users/sc0ttkclark/Applications/.

How

It may be possible to check for apps in both directories without having to make this JetBrains Toolbox specific.

The logic in https://github.com/Automattic/studio/blob/trunk/src/lib/is-installed.ts could be updated to have the function isInstalled check if the process.platform != 'win32' and in that case it would check if the fs.existsSync( appPaths[ key ] ) OR fs.existsSync( userPathPrefix + appPaths[ key ] ).

Something like that could perhaps be done.

@sc0ttkclark sc0ttkclark added the [Type] Enhancement Improvement upon an existing feature label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improvement upon an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant