Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate and describe Tracks events for the WP-CLI run via VIP-CLI #415

Open
simonwheatley opened this issue Jul 15, 2019 · 3 comments
Open

Validate and describe Tracks events for the WP-CLI run via VIP-CLI #415

simonwheatley opened this issue Jul 15, 2019 · 3 comments
Labels
[Type] Enhancement New feature or request
Milestone
WP-CLI Commands 3

Comments

@simonwheatley
Copy link
Contributor

Currently the vip_cli_wpcli_* Tracks Events are unvalidated and undescribed, we should validate them and describe them :)
@simonwheatley simonwheatley added the [Type] Enhancement New feature or request label Jul 15, 2019
@joshbetz
Copy link
Contributor

What does validating and describing entail?

@elazzabi
Copy link
Member

Looking at the current master branch. It looks like we somehow lost the tracking we had and now we are tracking the confirm_cancel event only https://github.com/Automattic/vip/blob/master/src/bin/vip-wp.js#L146

I think this is a good opportunity to pause and ask what questions are we trying to answer and build the events that can help us responding to them.

@simonwheatley lets brainstorm some questions and work out how we can track them.

@simonwheatley
Copy link
Contributor Author

Cross-linking some internal discussion: https://wp.me/p6jPRI-2iF/#comment-15731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Enhancement New feature or request
Projects
None yet
Milestone
WP-CLI Commands 3
Development

No branches or pull requests
3 participants
@simonwheatley @joshbetz @elazzabi