Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP: Add Cluster support #12

Open
mjangda opened this issue Aug 8, 2018 · 5 comments
Open

HTTP: Add Cluster support #12

mjangda opened this issue Aug 8, 2018 · 5 comments
Milestone

Comments

@mjangda
Copy link
Member

mjangda commented Aug 8, 2018

Via @nickdaugherty in #8 (comment)

Oh another consideration, and something we don't necessarily have to support in this PR, is using Node Cluster for more resilient and performant apps out of the box.

The library could abstract away and hide the details of setting up a clustered process, though maybe should only be enabled with an option since it requires the application to be written with multi process in mind.

For an example of how we're using Cluster on Go now (but sadly only using a single worker), see the public API repo.

@mjangda mjangda added this to the v0.2 milestone Aug 10, 2018
@mjangda mjangda modified the milestones: v0.2, v0.3 Oct 10, 2018
@mjangda
Copy link
Member Author

mjangda commented Oct 30, 2018

Continued in #41

@mjangda mjangda closed this as completed Oct 30, 2018
@nickdaugherty
Copy link
Member

Oops, I guess I missed this one when opening #41

@nickdaugherty
Copy link
Member

Oh actually, #41 was for Logging specifically (really just logging which worker an event occurred on). This issue was for adding Cluster to the core server itself.

@mjangda
Copy link
Member Author

mjangda commented Oct 31, 2018

Ah, got it.

@mjangda mjangda reopened this Oct 31, 2018
@nickdaugherty
Copy link
Member

When implementing this, we need to consider websocket support, which requires sticky routing to the same worker for the "polling" transport (default mode). That needs to be implemented in a performant and reliable way (public API depends on it if we want to use this base server for that...and we do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants