Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using a "N/A" as fee value on the Transactions listing #8286

Open
kalessil opened this issue Feb 28, 2024 · 1 comment · May be fixed by #8640
Open

Avoid using a "N/A" as fee value on the Transactions listing #8286

kalessil opened this issue Feb 28, 2024 · 1 comment · May be fixed by #8640
Labels
component: application fees Issues related to collecting fees component: transactions Issues related to Transactions focus: payments acceptance & processing good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. needs prioritisation Triage finished and issues are ready for the following processing. type: bug The issue is a confirmed bug.

Comments

@kalessil
Copy link
Contributor

Describe the bug

When the transaction fee is 0, the transaction listing page displays it as N/A instead of the expected number (the transaction details page handles the case correctly).

To Reproduce

  • Using a US merchant, assign wcpay-discount-100-off and refresh the client cache
  • Perform a test purchase (any payment method)
  • Check the transactions listing page and compare it to transaction details page

Screenshots

Screenshot from 2024-02-28 14-16-57

Screenshot from 2024-02-28 14-20-45
@kalessil kalessil added the type: bug The issue is a confirmed bug. label Feb 28, 2024
@kalessil kalessil changed the title Avoid using a "N/A" as fee values in the Transactions listing Avoid using a "N/A" as fee value on the Transactions listing Feb 28, 2024
@htdat htdat added component: transactions Issues related to Transactions needs prioritisation Triage finished and issues are ready for the following processing. good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. component: application fees Issues related to collecting fees gamma-priority-4 and removed gamma-priority-4 labels Feb 29, 2024
@SpaceSurfer1 SpaceSurfer1 linked a pull request Apr 14, 2024 that will close this issue
Open
6 tasks
@SpaceSurfer1
Copy link

Hi @kalessil , PR #8640 created for the issue. Now, if the fee value will be 0, number will be displayed instead of N/A. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: application fees Issues related to collecting fees component: transactions Issues related to Transactions focus: payments acceptance & processing good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. needs prioritisation Triage finished and issues are ready for the following processing. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

display 0 fee value as number instead of N/A in transaction list SpaceSurfer1/woocommerce-payments
4 participants
@kalessil @haszari @htdat @SpaceSurfer1