Add unit test for Get_Reporting_Payment_Activity. #8785
+88
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
Jinksi
approved these changes
May 20, 2024
There was a problem hiding this comment.
LGTM @shendy-a8c 🙌
💭 It may be worth adding a test for set_date_end in addition to set_date_start date validation, but this is low-risk since they use the same validation logic.
| */ | ||
| private $mock_api_client; | ||
| /** | ||
| * Mock WC_Payments_API_Client. |
There was a problem hiding this comment.
⛏️ code comment correction
Suggested change
| * Mock WC_Payments_API_Client. | |
| * Mock WC_Payments_Http_Interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8779
Changes proposed in this Pull Request
Add unit test for Get_Reporting_Payment_Activity.
Testing instructions
Get_Reporting_Payment_Activity_Testand I don't have copy-paste errors.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge