From fbe25b30ca747b7fbaba8c40d9bf196b9a8716f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9rgio=20Gomes?= Date: Mon, 12 Aug 2019 12:44:22 +0100 Subject: [PATCH] Prevent duplicate Babel object spread helpers. (#35136) * Prevent duplicate Babel object spread helpers. With version 7.5.x of Babel, the object spread helper was updated to fix some issues. When we upgraded Babel to 7.5.5, it started trying to use the new helper to perform object spreads. This would have been fine, since the relevant package (transform-runtime) was part of the upgrade, but Babel sadly assumes that its version is older, instead of auto-detecting. This change explicitly indicates which version of the transform-runtime we're using, fixing the issue. It unfortunately adds extra maintenance overhead to Babel upgrades, but the Babel authors are considering adding the aforemention auto-detection, at which point we could remove the explicit definition. See https://github.com/babel/babel/issues/10261 * Add note to changelog. * Add issue comment to Babel config too. --- packages/calypso-build/CHANGELOG.md | 5 +++++ packages/calypso-build/babel/default.js | 3 +++ 2 files changed, 8 insertions(+) diff --git a/packages/calypso-build/CHANGELOG.md b/packages/calypso-build/CHANGELOG.md index 0e50ca2c4187b..9dab739b74cae 100644 --- a/packages/calypso-build/CHANGELOG.md +++ b/packages/calypso-build/CHANGELOG.md @@ -1,3 +1,8 @@ +# [Unreleased] + +- Added transform-runtime versioning to babel/default.js + This will need to be kept up to date while https://github.com/babel/babel/issues/10261 is unresolved. + # 3.0.0 - Switch to `@wordpress/dependency-extraction-webpack-plugin` from diff --git a/packages/calypso-build/babel/default.js b/packages/calypso-build/babel/default.js index a8daff26c7695..021904d6579af 100644 --- a/packages/calypso-build/babel/default.js +++ b/packages/calypso-build/babel/default.js @@ -22,6 +22,9 @@ module.exports = () => ( { helpers: true, regenerator: false, useESModules: false, + // Needed so that helpers aren't duplicated. + // This will need to be kept up to date while https://github.com/babel/babel/issues/10261 is unresolved. + version: '7.5.5', }, ], ],