Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint rule to error on problematic language #43600

Closed
sarayourfriend opened this issue Jun 24, 2020 · 1 comment · Fixed by #43691
Closed

Add ESLint rule to error on problematic language #43600

sarayourfriend opened this issue Jun 24, 2020 · 1 comment · Fixed by #43691
Assignees

Comments

@sarayourfriend
Copy link
Contributor

In order to avoid introducing new instances of problematic language.

To accomplish this we could use the id-blacklist rule. While as of today it is woefully (and in this case quite ironically) named, the ESLint project is undergoing the same process as us in removing this kind of problematic language: eslint/eslint#13407

We could either (a) go ahead and add it using the current id-blacklist named rule or (b) wait until ESLint have updated it, upgrade our dependency and then use the newly renamed rule. Either way, we should keep our eyes on eslint/eslint#13408, once it is merged and a new ESLint release is cut we can do the upgrade.

As far as the list of terms to add to the rule configuration, I think we could start with the following:

  1. "whitelist"
  2. "blacklist"
  3. "master"
  4. "slave"
@sarayourfriend
Copy link
Contributor Author

There's actually already a project that does this: https://github.com/muenzpraeger/eslint-plugin-inclusive-language

The advantage to using that project is that it also provides helpful suggestions for alternatives, making maintenance around the issue as easy as possible 😁

sarayourfriend added a commit that referenced this issue Jul 1, 2020
* ESLint: Add inclusive language rule #43600

* ESLint: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant