Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for supported engines to import CaptureStep #90625

Merged

Conversation

daledupreez
Copy link
Contributor

@daledupreez daledupreez commented May 13, 2024

Proposed Changes

  • This PR ensures that we support the specified import platform before we redirect to the preview step in import flows.

Testing Instructions

  • Run this branch locally or via Calypso.live
  • Navigate to /setup/import-hosted-site
  • On the screen asking for your site address, enter a site built with Godaddy's site builder (which should be hosted at *.godaddysites.com)
  • Verify that you are taken to a screen that indicates we don't support imports from that platform

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@daledupreez daledupreez requested a review from a team May 13, 2024 12:05
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2024
@daledupreez daledupreez self-assigned this May 13, 2024
@daledupreez daledupreez added Import Site Importer Site Importer related issues labels May 13, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~544 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
import-hosted-site-flow       +133 B  (+0.0%)     +358 B  (+0.2%)
import-flow                   +133 B  (+0.0%)     +286 B  (+0.0%)
import                        +133 B  (+0.0%)     +258 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@andres-blanco
Copy link
Contributor

This doesn't seem to fix the issue

Screen.Recording.2024-05-13.at.09.14.05.mov

@daledupreez
Copy link
Contributor Author

@andres-blanco, did you follow the flow from the start? It shouldn't take you to the preview step after entering the URL -- you should end up on a step saying that we can't import your content.

@andres-blanco
Copy link
Contributor

andres-blanco commented May 13, 2024

did you follow the flow from the start? It shouldn't take you to the preview step after entering the URL -- you should end up on a step saying that we can't import your content.

nope, direct link. When going through the whole flow I get to the expected screen:
image

Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Noting that we should consolidate the list of supported importers, more on this in this thread p1715595249244569-slack-C0Q664T29

@daledupreez
Copy link
Contributor Author

I created #90635 to track the divergent lists of available importers.

@daledupreez daledupreez marked this pull request as ready for review May 14, 2024 10:48
@daledupreez daledupreez requested a review from a team as a code owner May 14, 2024 10:48
@daledupreez daledupreez merged commit 9b19be2 into trunk May 14, 2024
17 of 18 checks passed
@daledupreez daledupreez deleted the fix/import-handling-for-known-but-not-supported-platforms branch May 14, 2024 10:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Import Site Importer Site Importer related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants