From 6d77447ac1c2a5f6af02c9fa0525d34ffd5e133d Mon Sep 17 00:00:00 2001 From: Philip Jackson Date: Fri, 12 Feb 2021 17:33:38 +1300 Subject: [PATCH 1/2] Disable the jsx-a11y/no-onchange lint rule As outlined in jsx-eslint/eslint-plugin-jsx-a11y#398, the rule is no longer relevant. It goes against the official React docs and keyboard navigation in with keyboards this addressed don't appear to be an issue anymore + // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/398 + 'jsx-a11y/no-onchange': 'off', + 'no-restricted-imports': [ 2, { From 7dfe1f1c547cb301abd0f6a482f7d69ff3dc5f13 Mon Sep 17 00:00:00 2001 From: Philip Jackson Date: Fri, 12 Feb 2021 17:38:49 +1300 Subject: [PATCH 2/2] Remove unnecessary lint rule exceptions --- client/blocks/site-address-changer/index.jsx | 2 -- client/components/forms/form-country-select/index.jsx | 2 -- .../checkout/composite-checkout/payment-methods/ebanx-tef.js | 2 -- client/my-sites/google-my-business/stats/chart.js | 2 -- client/my-sites/marketing/connections/mailchimp-settings.jsx | 2 -- packages/composite-checkout/src/lib/payment-methods/ideal.js | 2 -- 6 files changed, 12 deletions(-) diff --git a/client/blocks/site-address-changer/index.jsx b/client/blocks/site-address-changer/index.jsx index 1ac5ae869eda8..fba50ef301f77 100644 --- a/client/blocks/site-address-changer/index.jsx +++ b/client/blocks/site-address-changer/index.jsx @@ -1,5 +1,3 @@ -/* eslint-disable jsx-a11y/no-onchange */ - /** * External dependencies */ diff --git a/client/components/forms/form-country-select/index.jsx b/client/components/forms/form-country-select/index.jsx index a85b68920a772..ea6917b68ef36 100644 --- a/client/components/forms/form-country-select/index.jsx +++ b/client/components/forms/form-country-select/index.jsx @@ -17,7 +17,6 @@ import FormSelect from 'calypso/components/forms/form-select'; */ import './style.scss'; -/* eslint-disable jsx-a11y/no-onchange */ export class FormCountrySelect extends Component { static propTypes = { countriesList: PropTypes.array.isRequired, @@ -74,6 +73,5 @@ export class FormCountrySelect extends Component { ); } } -/* eslint-enable jsx-a11y/no-onchange */ export default localize( FormCountrySelect ); diff --git a/client/my-sites/checkout/composite-checkout/payment-methods/ebanx-tef.js b/client/my-sites/checkout/composite-checkout/payment-methods/ebanx-tef.js index 34d6903a19beb..972b2cf2e73b2 100644 --- a/client/my-sites/checkout/composite-checkout/payment-methods/ebanx-tef.js +++ b/client/my-sites/checkout/composite-checkout/payment-methods/ebanx-tef.js @@ -204,7 +204,6 @@ function EbanxTefFields() { function BankSelector( { id, value, onChange, label, isError, errorMessage, disabled } ) { const { __ } = useI18n(); const bankOptions = getBankOptions( __ ); - /* eslint-disable jsx-a11y/no-onchange */ return ( ); - /* eslint-enable jsx-a11y/no-onchange */ } function BankOption( { value, label } ) { diff --git a/client/my-sites/google-my-business/stats/chart.js b/client/my-sites/google-my-business/stats/chart.js index 34f1144ec90e7..a69e43e5e75bc 100644 --- a/client/my-sites/google-my-business/stats/chart.js +++ b/client/my-sites/google-my-business/stats/chart.js @@ -97,7 +97,6 @@ function getAggregation( props ) { } /* eslint-disable wpcalypso/jsx-classname-namespace */ -/* eslint-disable jsx-a11y/no-onchange */ class GoogleMyBusinessStatsChart extends Component { static propTypes = { @@ -311,7 +310,6 @@ class GoogleMyBusinessStatsChart extends Component { } } /* eslint-enable wpcalypso/jsx-classname-namespace */ -/* eslint-enable jsx-a11y/no-onchange */ export default connect( ( state, ownProps ) => { diff --git a/client/my-sites/marketing/connections/mailchimp-settings.jsx b/client/my-sites/marketing/connections/mailchimp-settings.jsx index 9ff5a3bcfd577..d37f094362cc6 100644 --- a/client/my-sites/marketing/connections/mailchimp-settings.jsx +++ b/client/my-sites/marketing/connections/mailchimp-settings.jsx @@ -92,7 +92,6 @@ const MailchimpSettings = ( { ); } - /* eslint-disable jsx-a11y/no-onchange */ return (
@@ -132,7 +131,6 @@ const MailchimpSettings = ( { { common }
); - /* eslint-enable jsx-a11y/no-onchange */ }; export const renderMailchimpLogo = () => ( diff --git a/packages/composite-checkout/src/lib/payment-methods/ideal.js b/packages/composite-checkout/src/lib/payment-methods/ideal.js index 4cba9263d51bb..e73a1642a2e50 100644 --- a/packages/composite-checkout/src/lib/payment-methods/ideal.js +++ b/packages/composite-checkout/src/lib/payment-methods/ideal.js @@ -118,7 +118,6 @@ function IdealFields() { function BankSelector( { id, value, onChange, label, isError, errorMessage, disabled } ) { const { __ } = useI18n(); const bankOptions = getBankOptions( __ ); - /* eslint-disable jsx-a11y/no-onchange */ return ( ); - /* eslint-enable jsx-a11y/no-onchange */ } function BankOption( { value, label } ) {