Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Improvement: Status controls could have a way to have icons instead of the default letters #1157

Open
4 tasks
gbritoda opened this issue Apr 11, 2024 · 8 comments
Assignees
Labels
🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed

Comments

@gbritoda
Copy link

Description
For the Status GUI control, instead of showing E, S, I and W, it would be nice to have a way to put icons in it instead.

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%
  • Propagate any change on the demos and run all of them to ensure there is no breaking change
  • Ensure any change is well documented
  • Status control from TaiPy gui can have Icons instead of the default letters
@gbritoda gbritoda added the 📈 Improvement Improvement of a feature. label Apr 11, 2024
@jrobinAV jrobinAV added the 🖰 GUI Related to GUI label Apr 19, 2024
@pravintargaryen
Copy link

Please assign this to me

@jrobinAV
Copy link
Member

jrobinAV commented Apr 22, 2024

Hello @pravintargaryen,

Our core maintainer team still needs to review this issue. We are still determining if or how we want to include it in the taipy library. Please give us some time to review the issue before engaging it. This should not be long.

Meanwhile, I invite you to look at the issues with the labels "good first issue" or "Help wanted". These tickets have been reviewed, approved and are opened for a contribution.

thank you.

@jrobinAV jrobinAV added 🆘 Help wanted Open to participation from the community 🟨 Priority: Medium Not blocking but should be addressed labels May 3, 2024
@jrobinAV
Copy link
Member

jrobinAV commented May 3, 2024

Hello @pravintargaryen,

The issue has been reviewed. Thank you for volunteering. Go ahead, give it a try.
This is not so easy, so make sure you get in touch with the appropriate maintainers:
@FredLL-Avaiga @FabienLelaquais @dinhlongviolin1 @namnguyen20999

@FabienLelaquais
Copy link
Member

Thank you @jrobinAV and @pravintargaryen

The real difficulty is going to be to keep the control's property API backward compatible.
We certainly can help designing this.

@jrobinAV
Copy link
Member

Hello @pravintargaryen,

Any news on the issue?

Cheers,

@pravintargaryen
Copy link

Hi @jrobinAV,

Apologies for being behind schedule

Working on new icons from Material UI for the frontend status component. Have to test it though.

\taipy\frontend\taipy-gui\src\components\Taipy\Status.tsx
\taipy\frontend\taipy-gui\src\components\Taipy\StatusList.tsx

1

@jrobinAV
Copy link
Member

No pb. Take the time you need, of course.

@FredLL-Avaiga
Copy link
Member

Hi @jrobinAV,

Apologies for being behind schedule

Working on new icons from Material UI for the frontend status component. Have to test it though.

\taipy\frontend\taipy-gui\src\components\Taipy\Status.tsx \taipy\frontend\taipy-gui\src\components\Taipy\StatusList.tsx

1

Are the new icons "in line" with the icons we already use ?
I thought you'd design a way to provide external icons ie allows the developer to add icons without changing the taipy-gui bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed
Projects
None yet
Development

No branches or pull requests

5 participants