Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more information in the compare_scenarios function #1233

Open
3 tasks
FlorianJacta opened this issue Apr 25, 2024 · 2 comments
Open
3 tasks

Expose more information in the compare_scenarios function #1233

FlorianJacta opened this issue Apr 25, 2024 · 2 comments
Labels
Core Related to Taipy Core 💬 Discussion Requires some discussion and decision 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed 🔒 Staff only Can only be assigned to the Taipy R&D team

Comments

@FlorianJacta
Copy link
Member

FlorianJacta commented Apr 25, 2024

Description
The goal is to have more information as parameters of the comparator functions so that the user can create the proper comparison. For example, the user doesn't know in the comparison function which scenarios he is comparing.

An idea could be to have the data nodes themselves as parameters and not their data.

This issue comes from this discussion:
Avaiga/taipy-doc#932 (comment)

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%
  • Propagate any change on the demos and run all of them to ensure there is no breaking change
  • Ensure any change is well documented
@FlorianJacta FlorianJacta added Core Related to Taipy Core 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed labels Apr 25, 2024
@jrobinAV
Copy link
Member

One concern I have is that a data node may belong to multiple scenarios depending on its scope.
Passing only the data nodes can't help you get the corresponding scenario.

@FlorianJacta
Copy link
Member Author

The parent_id would be what interests me here.

@jrobinAV jrobinAV added 🔒 Staff only Can only be assigned to the Taipy R&D team 💬 Discussion Requires some discussion and decision labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to Taipy Core 💬 Discussion Requires some discussion and decision 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed 🔒 Staff only Can only be assigned to the Taipy R&D team
Projects
None yet
Development

No branches or pull requests

2 participants