module.hot is always true

[KaseyPowers]

availity-workflow/packages/availity-react-kit/project/app/index.js

Line 26 in 0683816

if (__DEV__ && module.hot) {

the plugin is always added currently, so even if hot reloading is turned off in the config, this statement will be true

[robmcguinness]

Possible solution: https://github.com/NoamELB/react-hot-loader-loader

[robmcguinness]

I believe this is solved with https://github.com/Availity/availity-workflow/releases/tag/v4.0.0-alpha.0

[TheSharpieOne]

How are you turning it off?
I see this in the docs which references development.hot:

    development: {
        notification: true
        hot: true
    },

but that property is not used AFAICT. development.hotLoader is used for the webpack config via settings call:

availity-workflow/packages/workflow-settings/index.js

Lines 328 to 330 in f6933da

	isHotLoader() {
	return get(this.configuration, 'development.hotLoader', true);
	},

hot is used by webpack dev server, but to set that you need development.webpackDevServer.hot to override the default of true

I am not sure if these values should always be the same, but it seems like it. (so that webpack dev server only hot when the webpack hot plugins and loaders are enabled, and the webpack hot plugin and loaders are only enabled when the webpack dev server is hot)
I tried it out locally, it "worked" it was no longer hot... but then I ran into webpack/webpack-dev-server#1251 which means without hot, it will fallback to "live reloading" and now every change reloads the page... which was not so great.

[GoPro16]

The new react-refresh babel loader is able to track hot reloads without having to modify the app code. Unless there is some dire need to make a change cause a full page refresh I don't see why this would be needed IIRC. I don't think CRA supports causing a full page refresh out of the box on code update.