Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table row shadow is visible when checkbox on the table row has focus #174

Open
boilund opened this issue Dec 3, 2021 · 1 comment
Open

Comments

@boilund
Copy link
Collaborator

boilund commented Dec 3, 2021

We usually don't show focus state in our components when using mouse. But Table row shadow is visible when checkbox on the table row is clicked because the checkbox has focus.
After this change

Actual behavior:
table-shadow-bug

Expected behavior:
Don't keep box shadow on table shadow when the checkbox is clicked.

@steabert
Copy link
Member

steabert commented Dec 8, 2021

I don't really see a convenient way to add this again without destroying the fix for menu. We used :focus-within to somehow select the row that has a child that is visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants