Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow image based questions from /api/conversation/azure_byod #752

Closed
3 tasks
Tracked by #323
adamdougal opened this issue Apr 24, 2024 · 3 comments
Closed
3 tasks
Tracked by #323

Allow image based questions from /api/conversation/azure_byod #752

adamdougal opened this issue Apr 24, 2024 · 3 comments
Labels
subtask A subtask

Comments

@adamdougal
Copy link
Collaborator

adamdougal commented Apr 24, 2024

Required by #323

Description

When calling the /api/conversation/azure_byod endpoint, generate embeddings of the question using computer vision and query the image embeddings using the question embeddings. We should continue to create question embeddings using text-embeddings-ada-002 in addition to be used to search the image description.

Tasks

  • Generate question embeddings using computer vision
  • Query the search index using the generated embeddings
  • Pass any returned images to gpt-4-vision along with the chat
@cecheta
Copy link
Collaborator

cecheta commented May 22, 2024

I'm not sure how you envision this @adamdougal , but I'm not sure it's possible, as Azure OpenAI on your data only supports vector search using Ada embeddings

@cecheta
Copy link
Collaborator

cecheta commented May 22, 2024

Is it that we use the user's question to find the closest images, and then we pass these image(s) to GPT-4?

If so, that seems like quite a lot of custom code for the BYOD endpoint, I had thought that the byod endpoint was essentially a wrapper for Azure OpenAI On Your Data without much customisation

@adamdougal
Copy link
Collaborator Author

I wasn't sure if it would be possible. If that's the case then we should ensure we document the limitation.

I don't think we should add any custom code to support this.

@cecheta cecheta closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subtask A subtask
Projects
None yet
Development

No branches or pull requests

2 participants