Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the PromptFlow from "On Your Data" and check it works with our index #915

Open
3 tasks done
Tracked by #406
gaurarpit opened this issue May 15, 2024 · 4 comments
Open
3 tasks done
Tracked by #406
Assignees
Labels
subtask A subtask

Comments

@gaurarpit
Copy link
Collaborator

gaurarpit commented May 15, 2024

Required by #406

Description

Create and deploy a flow which mimics the current converstation flow.

Tasks

@adamdougal
Copy link
Collaborator

Update 20th May:

  • Currently working on spiking the implementation
  • We've successfully replicated orchestration flow in prompt flow
  • We've successfully exported the flow and run this locally using pf flow serve ...
  • We're hitting an issue when trying to build the flow using pf flow build...

@adamdougal
Copy link
Collaborator

Further Update 20th May:

  • I've managed to get around the issue with the AI Search connection not being picked up by adding connection: aisearch_connection to the lookup node
  • I'm now running into another issue where running the built executable works, but sending queries through it results in a 401 -Unauthorized. Access token is missing, invalid, audience is incorrect (https://cognitiveservices.azure.com), or have expired. error when calling OpenAI.
    • I've checked the Key is correct and all is good
    • I'll continue to investigate

@adamdougal
Copy link
Collaborator

Update 21st May:

  • After receiving guidance from the prompt flow team, I have been able to deploy the flow to an AML endpoint
  • Discussed this with the team and this is more desirable than deploying to an App Service as it's closer to where the prompt flow is defined and experimentation is run
  • Next step is to work out how to deploy an AML endpoint using bicep

@adamdougal
Copy link
Collaborator

Update 24th May:

  • I've got the workspace and connections deploying successfully using Bicep
  • However, it does not seem to be possible to deploy a flow and a corresponding endpoint using Bicep
  • I've explored using deployment scripts, but these run on a container in Azure, it's not trivial to install the required dependencies (pfazure) and it does not have access to local files.
  • As a fallback, we could look at using a azd postprovision hook, which runs locally to deploy the flow. The main downside of this, is that there would be a manual step for users who deploy using one click deploy.
  • I'll discuss with the team to decide next steps.

adamdougal added a commit that referenced this issue May 29, 2024
- This deploys a basic version of the orchestration as a prompt flow end
  point
- It's not possible to create a flow just using bicep, so also leverages
  azd hooks to run a script to create the required resources
- Does not support features such as RBAC, advanced image processing,
  integrated vectorization etc
- Does not currently integrate with the applications, work for this is
  ongoing

Required by #915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subtask A subtask
Projects
None yet
Development

No branches or pull requests

3 participants