Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Recommend updating appservice.bicep to latest azure-dev files #460

Open
pamelafox opened this issue Apr 7, 2024 · 1 comment
Open
Assignees
Labels
good first issue Good for newcomers priority: P0 High priority scope: infra

Comments

@pamelafox
Copy link

In the original version of appservice.bicep, appSettings was not wrapped with an @secure decorator, so if a developer put any secrets in their app settings, it would leak into deployment outputs and cause a security alert. The latest version now has the secure decorator.

I noticed this repo is using the old version, so I recommend upgrading if you can.

You can git clone https://github.com/azure/azure-dev and then cp like this:

cp ../azure-dev/templates/common/infra/bicep/core/host/* infra/core/host/.

Or only cp app service files if you don't use other hosts:

cp ../azure-dev/templates/common/infra/bicep/core/host/appservice* infra/core/host/.

Then run azd up to make sure all still works.

@manekinekko
Copy link
Collaborator

Thanks @pamelafox for reporting this. The team will look into it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority: P0 High priority scope: infra
Projects
None yet
Development

No branches or pull requests

3 participants