Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect log during cancellation success flow #1797

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Remove incorrect log during cancellation success flow #1797

merged 1 commit into from
Jul 31, 2023
+1 −2

Conversation

liliankasem
Copy link
Member

Issue describing the changes in this PR

Bug: we should not be logging "unable to cancel" during a successful cancellation flow

resolves #1753

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Sorry, something went wrong.

@liliankasem liliankasem merged commit 15204b1 into main Jul 31, 2023
@liliankasem liliankasem deleted the liliankasem/remove-cancel-log branch July 31, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviau jviau

@surgupta-msft surgupta-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected "Unable to cancel invocation" warning log
3 participants
@liliankasem @jviau @surgupta-msft