Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[in-proc backport] Use dotnet common artifacts output (#9858) #10079

Closed
wants to merge 2 commits into from

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Apr 29, 2024

Backport of #9858

* Use dotnet common artifacts output

* Fix test paths

* Fix more tests

* Compress-Archive fix attempt

* Fix more tests

* Remove verbose log from build script

* Update build-extensions.ps1

* Remove release_* from esrp signing

* Force build

* Allow for packing via --pack

* Use powershell core --pack

* Force build --pack

* Fix pwsh --pack

* Upgrade back to .NET8

* Fix copy-paste error

* Fix Verify_DepsJsonChanges

* Undo SDK upgrade
# Conflicts:
#	build/build-extensions.ps1
#	test/WebJobs.Script.Tests.Integration/Controllers/ControllerScenarioTestFixture.cs
#	test/WebJobs.Script.Tests/DependencyTests.cs
@jviau jviau requested a review from a team as a code owner April 29, 2024 16:14
@liliankasem
Copy link
Member

liliankasem commented Apr 29, 2024

@jviau Can you remove the Update to .NET8 SDK commit?

@jviau
Copy link
Contributor Author

jviau commented Apr 29, 2024

@jviau Can you remove the Update to .NET8 SDK commit?

This functionality is only available in .NET8 SDK. We will also need this when mult-targeting net8 & net6 anyways.

I won't be checking this in until we resolve the docker build issue.

@liliankasem
Copy link
Member

liliankasem commented Apr 29, 2024

@jviau Can you remove the Update to .NET8 SDK commit?

This functionality is only available in .NET8 SDK. We will also need this when mult-targeting net8 & net6 anyways.

I won't be checking this in until we resolve the docker build issue.

Then I think this should be a separate PR, I think the backport PR should be purely backport only without any extra changes. We also want to put all .NET 8 changes into a feature branch first before bringing it all into in-proc. If it makes more sense, maybe these two PRs can point at the in-proc .net 8 feature branch

Edit: created a feature branch: https://github.com/Azure/azure-functions-host/tree/feature/in-proc8

@fabiocav
Copy link
Member

If this is blocked by the docker issues, we need to consider bringing this change to the feature branch used for multi-targeting.

@jviau
Copy link
Contributor Author

jviau commented May 16, 2024

This was ported in another PR

@jviau jviau closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants