Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[in-proc backport] Ensuring non http invocation responses are not processed by IHttpProxyService #9984 #10085

Merged
merged 1 commit into from Apr 30, 2024
Merged

[in-proc backport] Ensuring non http invocation responses are not processed by IHttpProxyService #9984 #10085

merged 1 commit into from Apr 30, 2024

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Apr 30, 2024

Backporting #9984

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kshyju
Ensuring non http invocation responses are not processed by IHttpProx…
844e820 
…yService (#9984)

* Fixing bug where non http invocation responses were going through IHttpProxyService.EnsureSuccessfulForwardingAsync

* Test cleanup

* Release notes and patch version bump.
@kshyju kshyju requested a review from a team as a code owner April 30, 2024 21:26
@liliankasem
Copy link
Member

I think Bump patch version number to 1 needs to be its own PR - we should keep backport PRs purely for cherry-picked commits

@kshyju kshyju merged commit 2662628 into in-proc Apr 30, 2024
6 checks passed
@kshyju kshyju deleted the shkr/backport_9984 branch April 30, 2024 23:31
kshyju added a commit that referenced this pull request Apr 30, 2024
@kshyju
Ensuring non http invocation responses are not processed by IHttpProx…
a9ce4db 
…yService (#9984) (#10085)

* Fixing bug where non http invocation responses were going through IHttpProxyService.EnsureSuccessfulForwardingAsync

* Test cleanup

* Release notes and patch version bump.
@kshyju kshyju mentioned this pull request Apr 30, 2024
Merged
kshyju added a commit that referenced this pull request Apr 30, 2024
@kshyju
Ensuring non http invocation responses are not processed by IHttpProx…
7b206e8 
…yService (#9984) (#10085)

* Fixing bug where non http invocation responses were going through IHttpProxyService.EnsureSuccessfulForwardingAsync

* Test cleanup

* Release notes and patch version bump.
@kshyju kshyju mentioned this pull request May 1, 2024
Merged
kshyju added a commit that referenced this pull request May 1, 2024
@kshyju
Ensuring non http invocation responses are not processed by IHttpProx…
2a98d6e 
…yService (#9984) (#10085)

* Fixing bug where non http invocation responses were going through IHttpProxyService.EnsureSuccessfulForwardingAsync

* Test cleanup

* Release notes and patch version bump.
@kshyju kshyju mentioned this pull request May 1, 2024
Merged
kshyju added a commit that referenced this pull request May 1, 2024
@kshyju
4.34.1 Hotfix (#10086)
07e9fb1 
* Ensuring non http invocation responses are not processed by IHttpProxyService (#9984) (#10085)

* Release notes and patch version bump.

* Bumping patch version number to 1.

* Update release notes.
kshyju added a commit that referenced this pull request May 1, 2024
@kshyju
4.634.1 Hotfix (#10087)
50ca0b9 
* Ensuring non http invocation responses are not processed by IHttpProxyService (#9984) (#10085)

* Release notes and patch version bump.

* Patch version bump and release notes updates.
kshyju added a commit that referenced this pull request May 1, 2024
@kshyju
4.834.1 Hotfix (#10088)
1f9f416 
* Ensuring non http invocation responses are not processed by IHttpProxyService (#9984) (#10085)

* Release notes and patch version bump.

* Bump up patch version number. Update release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliankasem liliankasem liliankasem approved these changes

@fabiocav fabiocav fabiocav approved these changes

@satvu satvu satvu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kshyju @liliankasem @fabiocav @satvu