Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default hostname changes (azurewebsites.net) #10090

Open
mathewc opened this issue May 1, 2024 · 0 comments
Open

Default hostname changes (azurewebsites.net) #10090

mathewc opened this issue May 1, 2024 · 0 comments

Comments

@mathewc
Copy link
Member

mathewc commented May 1, 2024

The App Service platform is moving to a strategy where the default hostname for a site will vary regionally. This means that code can't simply assume "azurewebsites.net".

New default hostname format: siteName-<dnlHash>.<region>.azurewebsites.net
SCM site will have this format:​ siteName-<dnlHash>.scm.<region>.azurewebsites.net

There are several known places in the host currently where we're using this string literal. We'll need to review all these and make changes as required. These include:

  • In defaulting the hostname used by the Host ID provider for Linux Dedicated (code here)
  • In constructing the Host ID for Linux Consumption (code here)
  • In the JWT issuer/audience values (code here). These aren't a problem and would be difficult to change anyways, since the App Service platform and Kudu are using these same values and rely on this contract.
  • FunctionsSyncManager uses the hostname to make Front End settriggers calls (code here). We need to make sure that the hostname value returned by the HostNameProvider is correct in all cases for these calls to work. For Linux Dedicated, I see there's already a problem - for that platform WEBSITE_HOSTNAME isn't set (at least it wasn't when the code was written), so it hardcodes "azurewebsites.net". This will need to change.

Note that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant