Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[in-proc8] Update deps json test for multi-target #10097

Merged
merged 7 commits into from
May 3, 2024

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented May 1, 2024

Issue describing the changes in this PR

#10044

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@liliankasem liliankasem requested a review from a team as a code owner May 1, 2024 23:40
@liliankasem liliankasem changed the title Update deps json test for multi-target [draft] Update deps json test for multi-target May 1, 2024
@liliankasem liliankasem closed this May 1, 2024
@liliankasem liliankasem reopened this May 2, 2024
@liliankasem liliankasem changed the title [draft] Update deps json test for multi-target Update deps json test for multi-target May 2, 2024
Copy link
Contributor

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan on multi-targeting our test projects also? Because that would change how this can be approached.

@liliankasem
Copy link
Member Author

Do we plan on multi-targeting our test projects also? Because that would change how this can be approached.

From what've seen, @fabiocav opted not to multi-target. I assume that was intentional

@liliankasem liliankasem changed the title Update deps json test for multi-target [in-proc8] Update deps json test for multi-target May 2, 2024
@liliankasem
Copy link
Member Author

deps file for .net6 stays the same. Here are the change s for net8

Removed:
- Grpc.AspNetCore.Server.ClientFactory.dll: 2.0.0.0/2.55.0.0
- Grpc.AspNetCore.Server.dll: 2.0.0.0/2.55.0.0
- Grpc.Net.Client.dll: 2.0.0.0/2.55.0.0
- Grpc.Net.ClientFactory.dll: 2.0.0.0/2.55.0.0
- Grpc.Net.Common.dll: 2.0.0.0/2.55.0.0
- System.Diagnostics.DiagnosticSource.dll: 6.0.0.0/6.0.1523.11507
- System.IO.Hashing.dll: 7.0.0.0/7.0.22.51805
- System.Text.Json.dll: 6.0.0.0/6.0.2523.51912
- Yarp.ReverseProxy.dll: 2.0.1.0/2.0.123.32202

Added:
- Grpc.AspNetCore.Server.ClientFactory.dll: 2.0.0.0/2.55.0.0
- Grpc.AspNetCore.Server.dll: 2.0.0.0/2.55.0.0
- Grpc.Net.Client.dll: 2.0.0.0/2.55.0.0
- Grpc.Net.ClientFactory.dll: 2.0.0.0/2.55.0.0
- Grpc.Net.Common.dll: 2.0.0.0/2.55.0.0
- System.IO.Hashing.dll: 7.0.0.0/7.0.22.51805
- Yarp.ReverseProxy.dll: 2.0.1.0/2.0.123.32202

Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in.

This will be reviewed again prior to final merge and the dependencies will also change as we move the references prior to the runtimeassemblies update.

@liliankasem liliankasem merged commit 4effc76 into feature/in-proc8 May 3, 2024
2 checks passed
@liliankasem liliankasem deleted the liliankasem/testfix/depsjsonpath branch May 3, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants