Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET 8 in-proc] Multi-target test projects #10117

Merged
merged 9 commits into from
May 9, 2024

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented May 6, 2024

Issue describing the changes in this PR

Part of #10044

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional Information

  • Updated test projects to multi-target net6 and net8
  • Updates ADO pipeline to run tests for both targets
  • Updated unit test to separate out EGM from other unit tests (this is a temporary change whilst @brettsam works on multi-targeting for the EGM project and it's test - consider it out of scope for this PR).

@liliankasem liliankasem force-pushed the liliankasem/in-proc8/multitarget-tests branch 3 times, most recently from 34cc147 to a7a1048 Compare May 7, 2024 22:32
@liliankasem liliankasem marked this pull request as ready for review May 7, 2024 22:37
@liliankasem liliankasem requested a review from a team as a code owner May 7, 2024 22:37
@liliankasem
Copy link
Member Author

@fabiocav - should I target this change into your clean branch for inproc8?

@liliankasem liliankasem changed the title Muli-target test projects [.NET 8 in-proc] Muli-target test projects May 7, 2024
@liliankasem liliankasem changed the title [.NET 8 in-proc] Muli-target test projects [.NET 8 in-proc] Multi-target test projects May 7, 2024
@liliankasem liliankasem changed the base branch from feature/in-proc8 to fabiocav/in-proc8-clean May 7, 2024 23:18
@liliankasem liliankasem force-pushed the liliankasem/in-proc8/multitarget-tests branch from a7a1048 to 44ed326 Compare May 7, 2024 23:39
Base automatically changed from fabiocav/in-proc8-clean to in-proc May 8, 2024 17:13
@liliankasem liliankasem force-pushed the liliankasem/in-proc8/multitarget-tests branch from 03c7b44 to 027dcf0 Compare May 8, 2024 17:28
@liliankasem liliankasem force-pushed the liliankasem/in-proc8/multitarget-tests branch from 027dcf0 to 7ae1226 Compare May 8, 2024 17:51
@liliankasem
Copy link
Member Author

@fabiocav pipeline is all green except for the artifact build conflict due to having to rerun for a flakey test - is it okay if we bypass and merge (once we have approvals):

https://azfunc.visualstudio.com/Azure%20Functions/_build/results?buildId=165693&view=results

I wrote up a Teams thread about this pipeline issue for us to follow up on.

@fabiocav fabiocav merged commit 22a24f2 into in-proc May 9, 2024
9 of 11 checks passed
@fabiocav fabiocav deleted the liliankasem/in-proc8/multitarget-tests branch May 9, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants