Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: FunctionsSyncServiceTests: Increase test due time & add tsc callback #10146

Merged
merged 2 commits into from
May 13, 2024

Conversation

liliankasem
Copy link
Member

Issue describing the changes in this PR

Part of #10135

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Increasing the test due time to something more reasonable

@liliankasem liliankasem requested a review from a team as a code owner May 9, 2024 22:11
@jviau
Copy link
Contributor

jviau commented May 9, 2024

Is there a way we can use mock callbacks to signal the expected method was called? This way we can increase the timeout significantly, but also end delaying once it is called. See #10128 for an example

@liliankasem
Copy link
Member Author

Is there a way we can use mock callbacks to signal the expected method was called? This way we can increase the timeout significantly, but also end delaying once it is called. See #10128 for an example

Will take a stab at this approach

@liliankasem liliankasem changed the title Flaky test: FunctionsSyncServiceTests: Increase test due time Flaky test: FunctionsSyncServiceTests: Increase test due time & add tsc callback May 9, 2024
@liliankasem liliankasem merged commit 61c075e into dev May 13, 2024
10 checks passed
@liliankasem liliankasem deleted the liliankasem/flaky/syncservicetests branch May 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants