Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host Release Prep PR v4.35.0 #10149

Closed
wants to merge 1 commit into from
Closed

Host Release Prep PR v4.35.0 #10149

wants to merge 1 commit into from

Conversation

v-imohammad
Copy link
Contributor

@v-imohammad v-imohammad commented May 10, 2024 •
edited

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@v-imohammad v-imohammad requested a review from a team as a code owner May 10, 2024 17:48
@v-imohammad v-imohammad changed the base branch from release/in-proc to in-proc May 10, 2024 17:52
@v-smanchem v-smanchem changed the base branch from in-proc to dev May 10, 2024 17:54
@v-smanchem v-smanchem changed the base branch from dev to in-proc May 10, 2024 17:54
fabiocav
fabiocav requested changes May 10, 2024
View reviewed changes
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on this until the multi-targeting changes are done.

@fabiocav
Copy link
Member

Closing this so we can discuss 4.35.

@fabiocav fabiocav closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocav fabiocav fabiocav requested changes

@jviau jviau Awaiting requested review from jviau

@brettsam brettsam Awaiting requested review from brettsam

@vrdmr vrdmr Awaiting requested review from vrdmr

@pragnagopa pragnagopa Awaiting requested review from pragnagopa

@eliaslopezgt eliaslopezgt Awaiting requested review from eliaslopezgt

@VpOfEngineering VpOfEngineering Awaiting requested review from VpOfEngineering

@mathewc mathewc Awaiting requested review from mathewc

@gavin-aguiar gavin-aguiar Awaiting requested review from gavin-aguiar

@YunchuWang YunchuWang Awaiting requested review from YunchuWang

@pdthummar pdthummar Awaiting requested review from pdthummar

@hallvictoria hallvictoria Awaiting requested review from hallvictoria

Assignees
No one assigned
Labels
Needs: Author Feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@v-imohammad @fabiocav