Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suppressions.yaml] Merge multiple files up the directory tree #28942

Open
mikeharder opened this issue May 2, 2024 · 0 comments
Open

[suppressions.yaml] Merge multiple files up the directory tree #28942

mikeharder opened this issue May 2, 2024 · 0 comments
Assignees
Labels
Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikeharder
Copy link
Member

mikeharder commented May 2, 2024

When loading suppressions, merge all suppressions.yaml files found up the directory tree, from the fileUnderAnalysis to the root.

The merge is append-only, and the suppressions files are ordered from "closest to fileUnderAnalysis" to "closest to root". This is because tools may process suppressions as "first match wins", where this should match the suppressions file closest to the fileUnderAnalysis.

Also add end-to-end tests, generating files on disk dynamically at runtime (and of course run in parallel).

@mikeharder mikeharder self-assigned this May 2, 2024
@konrad-jamrozik konrad-jamrozik added Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: No status
Development

No branches or pull requests

2 participants