Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The unit tests of azure-core-metrics-opentelemetry failed when opentelemetry upgradding to 1.19.0 #31886

Closed
3 tasks done
moarychan opened this issue Nov 2, 2022 · 4 comments · Fixed by #31928
Closed
3 tasks done
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation

Comments

@moarychan
Copy link
Member

Describe the bug
Some unit tests of module azure-core-metrics-opentelemetry failed in the ci pipeline.

Exception or Stack Trace
The below log is from test class com.azure.core.metrics.opentelemetry.MetricsTests

io.opentelemetry.sdk.autoconfigure.spi.ConfigurationException: OTLP gRPC Metrics Exporter enabled but opentelemetry-exporter-otlp not found on classpath. Make sure to add it as a dependency to enable this feature.

To Reproduce
Upgrade to opentelemetry to 1.19.0, io.opentelemetry:opentelemetry-sdk-extension-autoconfigure to 1.19.0-alpha.
Or you can run the tests in branch feature/spring-boot-3

Code Snippet
N/A

Expected behavior
Compatible with the opentelemetry to 1.19.0 and 1.19.0-alpha.

Screenshots
N/A

Setup (please complete the following information):

  • OS: [Windows 11]
  • IDE: [IntelliJ]
  • Library/Libraries: [com.azure:azure-core-amqp:current]
  • Java version: [17]

Additional context
N/A

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Nov 2, 2022
@moarychan
Copy link
Member Author

Found this exception in this PR #31808 which is based on Spring Boot 3.0.0-RC1.

@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation labels Nov 2, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Nov 2, 2022
@joshfree
Copy link
Member

joshfree commented Nov 2, 2022

@lmolkova could you please take a look

@lmolkova
Copy link
Member

lmolkova commented Nov 2, 2022

@moarychan I tried to repro locally and all otel tests pass for me in feature/spring-boot-3 branch
Can you point me to the CI run and check if there were indeed otel metrics tests?

The error log you see (which I'd love to remove, but didn't get to it yet) does not indicate any issue for tests or users.

@lmolkova lmolkova assigned moarychan and unassigned lmolkova and moarychan Nov 2, 2022
@moarychan
Copy link
Member Author

Hi @lmolkova , the PR just merged, and the ci log is still available, please see the PR comment #31808 (comment)
image

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants