Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure @beta/@public and other tags come after the jsdoc description #12964

Closed
chriswhilar opened this issue Dec 17, 2020 · 5 comments
Closed
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs eslint plugin needs-team-attention This issue needs attention from Azure service team or SDK team

Comments

@chriswhilar
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Yes. If i put a tag before the tsdoc description like so:

/**
   * @beta
   * Join a meeting.
   * @param meetingLocator - Meeting information.
   * @param options - Call start options.
   * @returns The Call object associated with the call.
   */
    join(meetingLocator: MeetingLocator, options?: JoinCallOptions): Call;

eslint does not give me a warning or error about it. I feel like eslint should enforce for the description to come before any tags

Describe the solution you'd like
I would like for eslint to give me an error when there are tags before the description

Additional context
Not sure if eslint already supports this, but if it does please let me know.

@deyaaeldeen
Copy link
Member

Hi @chriswhilar, thanks for reporting this. Could you please tell me more about why this ordering matter?

@deyaaeldeen deyaaeldeen added Docs eslint plugin needs-author-feedback More information is needed from author to address the issue. labels Dec 17, 2020
@chriswhilar
Copy link
Contributor Author

Hey @deyaaeldeen, so the real issue im having is that if the description does not come first, then msft docs will not show the description in its generated docs so it may just be an issue on how msft is generating the docs.

But it also just seems more natural to enforce all tags to come after description anyways? Or if we can atleast create a eslint option rule to enforce this?

@ghost ghost added needs-team-attention This issue needs attention from Azure service team or SDK team and removed needs-author-feedback More information is needed from author to address the issue. labels Dec 17, 2020
@chriswhilar
Copy link
Contributor Author

@deyaaeldeen or maybe this could just be a msft docs generation bug?

@deyaaeldeen
Copy link
Member

@chriswhilar to give you a background, there are two things at play here. The syntax of our documentation comments and the tool we use for docs generation. For the former, we are half way through to have TSDoc comments everywhere. For the latter, we use TypeDoc which sadly does not yet support TSDoc officially but they plan to in v1.1 TypeStrong/typedoc#1266. So at the moment, TypeDoc does not understand many of TSDoc tags including @beta and most likely will stop once it sees something it does not understand.

For your question, I did some search and could not find any such eslint plugin. I also looked for plugins for TypeDoc for supporting some of the TSDoc tags but only found one for @example https://github.com/ardalanamini/typedoc-plugin-example-tag. However two plugins that caught my eye and maybe useful here are:
https://www.npmjs.com/package/typedoc-plugin-custom-tags
https://www.npmjs.com/package/typedoc-plugin-replace-in-comments

@deyaaeldeen deyaaeldeen added needs-author-feedback More information is needed from author to address the issue. customer-reported Issues that are reported by GitHub users external to the Azure organization. and removed needs-team-attention This issue needs attention from Azure service team or SDK team needs-author-feedback More information is needed from author to address the issue. labels Dec 18, 2020
@ghost ghost added the needs-team-attention This issue needs attention from Azure service team or SDK team label Dec 21, 2020
@deyaaeldeen deyaaeldeen removed the needs-team-attention This issue needs attention from Azure service team or SDK team label Dec 21, 2020
@ghost ghost added the needs-team-attention This issue needs attention from Azure service team or SDK team label Dec 21, 2020
@deyaaeldeen deyaaeldeen removed the needs-team-attention This issue needs attention from Azure service team or SDK team label Dec 21, 2020
@ghost ghost added the needs-team-attention This issue needs attention from Azure service team or SDK team label Dec 21, 2020
@ramya-rao-a
Copy link
Contributor

Closing this issue as we have no planned next steps here.

We have added a npm script docs for all our packages that are not purely auto generated. This can be used to generate the docs that are closest to what would appear in docs.microsoft.com/javascript/api. This can be used to review the docs before a package is published.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 31, 2021
[Resources] Import APIs for subscriptions.json file (Azure#12964)

* copy from 2020-01-01/subscriptions.json

* add changes for extended location

* Add examples copied from 2020-01-01

* add example for getting locations with extended locations

* add reference to example file

* Add extended location to resource definition.

* resolve comments

* update readme.md for subscriptions

* update error responses in subscriptions spec

* revert changes in common types

* remove changes in 2020-10-01. add 2021-01-01.

* copy subscriptions.json

* add changes for extended locations in 2021-01-01

* update version to 2021-01-01

* revert unwanted changes

* Fix readme

* add x-ms-mutability to extendedLocation property
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 31, 2021
[Resources] Import APIs for subscriptions.json file (Azure#12964)

* copy from 2020-01-01/subscriptions.json

* add changes for extended location

* Add examples copied from 2020-01-01

* add example for getting locations with extended locations

* add reference to example file

* Add extended location to resource definition.

* resolve comments

* update readme.md for subscriptions

* update error responses in subscriptions spec

* revert changes in common types

* remove changes in 2020-10-01. add 2021-01-01.

* copy subscriptions.json

* add changes for extended locations in 2021-01-01

* update version to 2021-01-01

* revert unwanted changes

* Fix readme

* add x-ms-mutability to extendedLocation property
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 31, 2021
[Resources] Import APIs for subscriptions.json file (Azure#12964)

* copy from 2020-01-01/subscriptions.json

* add changes for extended location

* Add examples copied from 2020-01-01

* add example for getting locations with extended locations

* add reference to example file

* Add extended location to resource definition.

* resolve comments

* update readme.md for subscriptions

* update error responses in subscriptions spec

* revert changes in common types

* remove changes in 2020-10-01. add 2021-01-01.

* copy subscriptions.json

* add changes for extended locations in 2021-01-01

* update version to 2021-01-01

* revert unwanted changes

* Fix readme

* add x-ms-mutability to extendedLocation property
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 31, 2021
[Resources] Import APIs for subscriptions.json file (Azure#12964)

* copy from 2020-01-01/subscriptions.json

* add changes for extended location

* Add examples copied from 2020-01-01

* add example for getting locations with extended locations

* add reference to example file

* Add extended location to resource definition.

* resolve comments

* update readme.md for subscriptions

* update error responses in subscriptions spec

* revert changes in common types

* remove changes in 2020-10-01. add 2021-01-01.

* copy subscriptions.json

* add changes for extended locations in 2021-01-01

* update version to 2021-01-01

* revert unwanted changes

* Fix readme

* add x-ms-mutability to extendedLocation property
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 31, 2021
[Resources] Import APIs for subscriptions.json file (Azure#12964)

* copy from 2020-01-01/subscriptions.json

* add changes for extended location

* Add examples copied from 2020-01-01

* add example for getting locations with extended locations

* add reference to example file

* Add extended location to resource definition.

* resolve comments

* update readme.md for subscriptions

* update error responses in subscriptions spec

* revert changes in common types

* remove changes in 2020-10-01. add 2021-01-01.

* copy subscriptions.json

* add changes for extended locations in 2021-01-01

* update version to 2021-01-01

* revert unwanted changes

* Fix readme

* add x-ms-mutability to extendedLocation property
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 31, 2021
[Resources] Import APIs for subscriptions.json file (Azure#12964)

* copy from 2020-01-01/subscriptions.json

* add changes for extended location

* Add examples copied from 2020-01-01

* add example for getting locations with extended locations

* add reference to example file

* Add extended location to resource definition.

* resolve comments

* update readme.md for subscriptions

* update error responses in subscriptions spec

* revert changes in common types

* remove changes in 2020-10-01. add 2021-01-01.

* copy subscriptions.json

* add changes for extended locations in 2021-01-01

* update version to 2021-01-01

* revert unwanted changes

* Fix readme

* add x-ms-mutability to extendedLocation property
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs eslint plugin needs-team-attention This issue needs attention from Azure service team or SDK team
Projects
None yet
Development

No branches or pull requests

4 participants