-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure @beta/@public and other tags come after the jsdoc description #12964
Comments
Hi @chriswhilar, thanks for reporting this. Could you please tell me more about why this ordering matter? |
Hey @deyaaeldeen, so the real issue im having is that if the description does not come first, then msft docs will not show the description in its generated docs so it may just be an issue on how msft is generating the docs. But it also just seems more natural to enforce all tags to come after description anyways? Or if we can atleast create a eslint option rule to enforce this? |
@deyaaeldeen or maybe this could just be a msft docs generation bug? |
@chriswhilar to give you a background, there are two things at play here. The syntax of our documentation comments and the tool we use for docs generation. For the former, we are half way through to have TSDoc comments everywhere. For the latter, we use For your question, I did some search and could not find any such eslint plugin. I also looked for plugins for |
Closing this issue as we have no planned next steps here. We have added a npm script |
[Resources] Import APIs for subscriptions.json file (Azure#12964) * copy from 2020-01-01/subscriptions.json * add changes for extended location * Add examples copied from 2020-01-01 * add example for getting locations with extended locations * add reference to example file * Add extended location to resource definition. * resolve comments * update readme.md for subscriptions * update error responses in subscriptions spec * revert changes in common types * remove changes in 2020-10-01. add 2021-01-01. * copy subscriptions.json * add changes for extended locations in 2021-01-01 * update version to 2021-01-01 * revert unwanted changes * Fix readme * add x-ms-mutability to extendedLocation property
[Resources] Import APIs for subscriptions.json file (Azure#12964) * copy from 2020-01-01/subscriptions.json * add changes for extended location * Add examples copied from 2020-01-01 * add example for getting locations with extended locations * add reference to example file * Add extended location to resource definition. * resolve comments * update readme.md for subscriptions * update error responses in subscriptions spec * revert changes in common types * remove changes in 2020-10-01. add 2021-01-01. * copy subscriptions.json * add changes for extended locations in 2021-01-01 * update version to 2021-01-01 * revert unwanted changes * Fix readme * add x-ms-mutability to extendedLocation property
[Resources] Import APIs for subscriptions.json file (Azure#12964) * copy from 2020-01-01/subscriptions.json * add changes for extended location * Add examples copied from 2020-01-01 * add example for getting locations with extended locations * add reference to example file * Add extended location to resource definition. * resolve comments * update readme.md for subscriptions * update error responses in subscriptions spec * revert changes in common types * remove changes in 2020-10-01. add 2021-01-01. * copy subscriptions.json * add changes for extended locations in 2021-01-01 * update version to 2021-01-01 * revert unwanted changes * Fix readme * add x-ms-mutability to extendedLocation property
[Resources] Import APIs for subscriptions.json file (Azure#12964) * copy from 2020-01-01/subscriptions.json * add changes for extended location * Add examples copied from 2020-01-01 * add example for getting locations with extended locations * add reference to example file * Add extended location to resource definition. * resolve comments * update readme.md for subscriptions * update error responses in subscriptions spec * revert changes in common types * remove changes in 2020-10-01. add 2021-01-01. * copy subscriptions.json * add changes for extended locations in 2021-01-01 * update version to 2021-01-01 * revert unwanted changes * Fix readme * add x-ms-mutability to extendedLocation property
[Resources] Import APIs for subscriptions.json file (Azure#12964) * copy from 2020-01-01/subscriptions.json * add changes for extended location * Add examples copied from 2020-01-01 * add example for getting locations with extended locations * add reference to example file * Add extended location to resource definition. * resolve comments * update readme.md for subscriptions * update error responses in subscriptions spec * revert changes in common types * remove changes in 2020-10-01. add 2021-01-01. * copy subscriptions.json * add changes for extended locations in 2021-01-01 * update version to 2021-01-01 * revert unwanted changes * Fix readme * add x-ms-mutability to extendedLocation property
[Resources] Import APIs for subscriptions.json file (Azure#12964) * copy from 2020-01-01/subscriptions.json * add changes for extended location * Add examples copied from 2020-01-01 * add example for getting locations with extended locations * add reference to example file * Add extended location to resource definition. * resolve comments * update readme.md for subscriptions * update error responses in subscriptions spec * revert changes in common types * remove changes in 2020-10-01. add 2021-01-01. * copy subscriptions.json * add changes for extended locations in 2021-01-01 * update version to 2021-01-01 * revert unwanted changes * Fix readme * add x-ms-mutability to extendedLocation property
Is your feature request related to a problem? Please describe.
Yes. If i put a tag before the tsdoc description like so:
eslint does not give me a warning or error about it. I feel like eslint should enforce for the description to come before any tags
Describe the solution you'd like
I would like for eslint to give me an error when there are tags before the description
Additional context
Not sure if eslint already supports this, but if it does please let me know.
The text was updated successfully, but these errors were encountered: