Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump in @azure/core-auth@1.6.0 to Node 18 was a breaking change and should have bumped major version #28547

Closed
1 of 6 tasks
jonthysell opened this issue Feb 9, 2024 · 2 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@jonthysell
Copy link

  • Package Name: @azure/core-auth
  • Package Version: 1.6.0
  • Operating system:
  • nodejs
    • version: 16.13.0
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
microsoft/react-native-windows relies on microsoft/ApplicationInsights-node.js which asks for @azure/core-auth@^1.5.0.

By introducing a breaking change in 1.6, it's now breaking internal customers downstream that have to maintain and support release branches on Node 16.

See the bug opened by affected customers of application insights: microsoft/ApplicationInsights-node.js#1274

See our bug: microsoft/react-native-windows#12711

To Reproduce
Steps to reproduce the behavior:

  1. npx --yes react-native@0.72.6 init test72 --template react-native@0.72.6
  2. npx react-native-windows-init

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
N/A

Additional context
N/A

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 10, 2024
@deyaaeldeen
Copy link
Member

It is interesting though that appinsights still supports NodeJS v8. Yeah we thought a lot about situations like this when we designed our support policy:

The Azure SDK libraries for JavaScript will not be guaranteed to work on Node.js versions that have reached their end of life. Dropping support for such Node.js versions may be done without increasing the major version of the Azure SDK libraries.

We found that it is expensive to maintain our SDKs across the board to work on top unmaintained runtimes which are often susceptible to vulnerabilities and lack support for newer, critical features.

@xirzec
Copy link
Member

xirzec commented Feb 12, 2024

This appears to be a duplicate of #28449

@xirzec xirzec closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

3 participants