Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ioredis samples for token refresh use cases #29644

Open
samsaha-ms opened this issue May 9, 2024 · 2 comments
Open

Enhance ioredis samples for token refresh use cases #29644

samsaha-ms opened this issue May 9, 2024 · 2 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone

Comments

@samsaha-ms
Copy link

Hello,
We request to enhance the ioredis samples here to better support the token refresh scenario along with clustered caches. Following are two asks we have:

  1. Current sample here https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/identity/identity/samples/AzureCacheForRedis/ioredis.md#migration-guidance-2, does not update the redis client object password field with new token after token refresh. This can be done by adding redis.options.password = accessTokenCache.token to update password with new token in client object as well after this line inside updateToken() function.
  2. Add a separate sample for clustered caches for token refresh. For clustered caches, we need to loop over each client node object and update password with new token and send auth command. Example can be found below.
    image
@github-actions github-actions bot added Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 9, 2024
Copy link

github-actions bot commented May 9, 2024

@KarishmaGhiya @maorleger

Copy link

github-actions bot commented May 9, 2024

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@scottaddie scottaddie added this to the 2024-06 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Status: Not Started
Development

No branches or pull requests

4 participants