Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ai-vision-face] should this package be under sdk/vision directory? #29670

Closed
jeremymeng opened this issue May 10, 2024 · 10 comments
Closed

[ai-vision-face] should this package be under sdk/vision directory? #29670

jeremymeng opened this issue May 10, 2024 · 10 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Vision

Comments

@jeremymeng
Copy link
Contributor

jeremymeng commented May 10, 2024

The package is currently at sdk/face/ai-vision-face-rest directory. face doesn't feel like an azure service.

There's already sdk/vision/ai-vision-image-analysis-rest there.

@jeremymeng jeremymeng added EngSys This issue is impacting the engineering system. Client This issue points to a problem in the data-plane of the library. labels May 10, 2024
@jeremymeng jeremymeng added Cognitive - Vision and removed EngSys This issue is impacting the engineering system. labels May 10, 2024
@chungshengfu
Copy link
Contributor

According to this documentation: What are Azure AI services?, face, vision, speech, document intelligence are parallel services, so current structure looks reasonable to me.
Besides, since they logically belong to Azure AI Services (formerly Azure Cognitive Services), probably the structure in azure-rest-api-spec is more like what you want? https://github.com/Azure/azure-rest-api-specs/tree/main/specification/ai

@jeremymeng
Copy link
Contributor Author

face, vision, speech, document intelligence are parallel services, so current structure looks reasonable to me.

Hmm, there must be a reason why vision is added before face? Also should image-analysis be moved out of vision directory if we follow api-specs structure? I see Face and ImageAnalysis there.

@xirzec
Copy link
Member

xirzec commented May 10, 2024

I see a 'vision' service folder in .NET and Python:

https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/vision
https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/vision

Neither seem to have this version of the SDK yet, only the old version under cognitiveservices.

@jeremymeng
Copy link
Contributor Author

Docs doesn't seem very consistent, I see Face is listed as one of AI Vision services here: https://learn.microsoft.com/en-us/azure/ai-services/computer-vision/

@Han-msft
Copy link
Member

I see a 'vision' service folder in .NET and Python:

https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/vision https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/vision

Neither seem to have this version of the SDK yet, only the old version under cognitiveservices.

Face SDK for the other languages are still under review. All of them are targeting sdk/face folder.
Computer vision and Face API are different service when creating resource in Azure. That's why we put SDK in different folders.
We should have a discussion with our PM if we need go to vision folder with image anaylsis.

.NET PR: Azure/azure-sdk-for-net#43820
Java PR: Azure/azure-sdk-for-java#40023
Python PR: Azure/azure-sdk-for-java#40023

@Han-msft
Copy link
Member

Han-msft commented May 16, 2024

Our PM said we should keep branding in vision for now, but it will be pull out of vision in the future.
We'd like to purpose staying at sdk/face to keep the flexibility.
We tried to move our code to sdk/vision in each language but encountered several pipeline issues.
JS got test failure.
Java got TypeSpec generation validation failure.
Since face and image analysis are separate services owned by separate teams, we should not block each other's development.
@xirzec @jeremymeng do you feel it's okay for us to stay at sdk/face?

@qiaozha
Copy link
Member

qiaozha commented May 16, 2024

@Han-msft I have a question, do you have independent service tree nodes?

@Han-msft
Copy link
Member

@Han-msft I have a question, do you have independent service tree nodes?

Yes, Face API is Cognitive Services Face API under Cognitive Vision.
https://microsoftservicetree.com/services/82b9a1cf-bbe3-488b-bdf9-fee717fa393a
Image analysis is a subset API in Cognitive Services Computer Vision API under Cognitive Vision.
https://microsoftservicetree.com/services/a2eae2da-667d-4b19-8789-9471e346ca84

@qiaozha
Copy link
Member

qiaozha commented May 16, 2024

Then I think it's fine to put them into two different folders.

@jeremymeng
Copy link
Contributor Author

@Han-msft thanks for confirming! I am fine with sdk/face too. It's not customer-facing and more for the consistency of our repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Vision
Projects
None yet
Development

No branches or pull requests

5 participants