Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@azure/app-configuration missing method to get multiple values #29695

Closed
caribou-code opened this issue May 14, 2024 · 4 comments
Closed

@azure/app-configuration missing method to get multiple values #29695

caribou-code opened this issue May 14, 2024 · 4 comments
Assignees
@minhanh-phan
Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@caribou-code
Copy link

caribou-code commented May 14, 2024 •
edited

The @azure/app-configuration package has a method to request a single key client.getConfigurationSetting(), which makes an API call behind the scenes. To get a set of 30 values, that means looping over each one and doing 30 API calls, which is not performant.

The App Config REST API supports requesting 5 keys in a single request, or using a wildcard selector such as web.foo.* (requires using pagination).

Can the @azure/app-configuration package be updated to support these endpoints to improve usage runtime performance?
@github-actions github-actions bot added App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team. labels May 14, 2024
@github-actions GitHub Actions
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @avanigupta @Eskibear.

@caribou-code caribou-code changed the title @azure/app-config missing method to get multiple values @azure/app-configuration missing method to get multiple values May 14, 2024
@minhanh-phan minhanh-phan self-assigned this May 14, 2024
@minhanh-phan
Copy link
Contributor

Hi @caribou-code, thank you so much for raising this issue. In our @azure/app-configuration SDK, we currently have listConfigurationSetting() method that has support for wildcard matching with keyFilter and labelFilter to get multiple settings. For more information on how to use this method, please feel free to check out this sample here. Please let us know if you have any extra questions in the meantime!

@minhanh-phan minhanh-phan added issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. and removed Service Attention This issue is responsible by Azure service team. needs-team-attention This issue needs attention from Azure service team or SDK team labels May 14, 2024
@github-actions GitHub Actions
Copy link

Hi @caribou-code. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

@caribou-code
Copy link
Author

@minhanh-phan you are correct! Not sure how I missed that, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minhanh-phan minhanh-phan

Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caribou-code @minhanh-phan