Resolve 1.11.1 causes build breaks

[mikeharder]

A breaking change was added to the resolve package between versions 1.11.0 to 1.11.1, which causes package rollup-plugin-node-resolve to fail bundling the buffer dependency.

• 1.11.1 breaks rollup-plugin-node-resolve browserify/resolve#194
• Resolve 1.11.1 breaks importing "shadowed" core modules e.g. buffer rollup/rollup-plugin-node-resolve#222

As a workaround, the package was pinned to version 1.11.0. We believe the correct long-term fix is rollup/rollup-plugin-node-resolve#222, and we may attempt to create a PR fixing that issue.

A second issue is that resolve@1.11.1 broke rollup-plugin-commonjs in a similar way (rollup/rollup-plugin-commonjs#394). The fix/workaround is to append a trailing slash to the named exports of modules with built-in names.

Related PRs

• Pin to version 1.11.0: Pin resolve to 1.11.0 #3456

[bterlson]

Put up a PR fixing this issue (I think) in rollup-plugin-node-resolve here.

[mikeharder]

When using resolve@1.11.1 and rollup-plugin-node-resolve@5.1.0 (latest versions of both), the issues with could not load <dependency> are fixed. However, the builds of storage-blob and storage-file are still broken due to another error:

ist-esm/src/index.browser.js ? browser/azure-storage-blob.js...
[!] Error: 'EventEmitter' is not exported by node_modules\events\events.js
https://rollupjs.org/guide/en#error-name-is-not-exported-by-module-
dist-esm\src\utils\Batch.js (4:9)
2: // In browser, during webpack or browserify bundling, this module will be replaced by 'events'
3: // https://github.com/Gozala/events
4: import { EventEmitter } from "events";
            ^
5: /**
6:  * States for Batch.
Error: 'EventEmitter' is not exported by node_modules\events\events.js
    at error (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:9234:30)
    at Module.error (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:13064:9)
    at handleMissingExport (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:12987:21)
    at Module.traceVariable (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:13364:17)
    at ModuleScope.findVariable (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:12111:39)
    at FunctionScope.findVariable (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:2890:38)
    at ChildScope.findVariable (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:2890:38)
    at FunctionScope.findVariable (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:2890:38)
    at ChildScope.findVariable (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:2890:38)
    at Identifier$1.bind (common\temp\node_modules\.registry.npmjs.org\rollup\1.13.1\node_modules\rollup\dist\rollup.js:8407:40)