Skip to content
This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Azure/go-autorest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: autorest/v0.11.17
Choose a base ref
...
head repository: Azure/go-autorest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: autorest/v0.11.18
Choose a head ref
  • 7 commits
  • 15 files changed
  • 1 contributor

Commits on Jan 15, 2021

  1. Update dependencies (#610)

    @jhendrixMSFT
    jhendrixMSFT authored Jan 15, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    c0fe8b0 View commit details

Commits on Feb 4, 2021

  1. Refactor managed identity detection logic (#613) 

    * Refactor managed identity authentication

* Fix MSI detection logic

* add test hook to fake IMDS endpoint being available

moved MSI-specific fields into ServicePrincipalMSISecret type.
refined MSI detection during token refresh.
set HTTP request method to GET for MSI requests.
fixed tests

* small clean-up

* fix cloudshell and add test

* fix nil sender

* allow msiEndpoint param to override default value

fixed up some more doc comments

* update docs

* add logging for detemining environment

* update test
    @jhendrixMSFT
    jhendrixMSFT authored Feb 4, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    def88ef View commit details

Commits on Feb 5, 2021

  1. Update auth to use updated managed identity detection (#614)

    @jhendrixMSFT
    jhendrixMSFT authored Feb 5, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    243526f View commit details

  2. Add LogAuth classification for logging authentication (#615) 

    * Add LogAuth classification for logging authentication

* improve doc comment
    @jhendrixMSFT
    jhendrixMSFT authored Feb 5, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    820a319 View commit details

  3. Add logging for authentication requests/responses (#616) 

    The logging of request/response bodies is explicitly opt-in via the
LogAuth setting, so that LogDebug won't disclose credential data.
    @jhendrixMSFT
    jhendrixMSFT authored Feb 5, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    8c0b29a View commit details

Commits on Feb 10, 2021

  1. Return an error if resp and err are nil (#617) 

    This will allow retry logic to kick in and also avoid up-stream panics
due to both the response and the error being nil.
    @jhendrixMSFT
    jhendrixMSFT authored Feb 10, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    79a63e7 View commit details

  2. Return an error if resp and err are nil (#618)

    @jhendrixMSFT
    jhendrixMSFT authored Feb 10, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    c7f947c View commit details
1 change: 1 addition & 0 deletions autorest/adal/go.mod
View file
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@ require (
github.com/Azure/go-autorest v14.2.0+incompatible
github.com/Azure/go-autorest/autorest/date v0.3.0
github.com/Azure/go-autorest/autorest/mocks v0.4.1
github.com/Azure/go-autorest/logger v0.2.1
github.com/Azure/go-autorest/tracing v0.6.0
github.com/form3tech-oss/jwt-go v3.2.2+incompatible
golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0
2 changes: 2 additions & 0 deletions autorest/adal/go.sum
View file
Original file line number Diff line number Diff line change
@@ -4,6 +4,8 @@ github.com/Azure/go-autorest/autorest/date v0.3.0 h1:7gUk1U5M/CQbp9WoqinNzJar+8K
github.com/Azure/go-autorest/autorest/date v0.3.0/go.mod h1:BI0uouVdmngYNUzGWeSYnokU+TrmwEsOqdt8Y6sso74=
github.com/Azure/go-autorest/autorest/mocks v0.4.1 h1:K0laFcLE6VLTOwNgSxaGbUcLPuGXlNkbVvq4cW4nIHk=
github.com/Azure/go-autorest/autorest/mocks v0.4.1/go.mod h1:LTp+uSrOhSkaKrUy935gNZuuIPPVsHlr9DSOxSayd+k=
github.com/Azure/go-autorest/logger v0.2.1 h1:IG7i4p/mDa2Ce4TRyAO8IHnVhAVF3RFU+ZtXWSmf4Tg=
github.com/Azure/go-autorest/logger v0.2.1/go.mod h1:T9E3cAhj2VqvPOtCYAvby9aBXkZmbF5NWuPV8+WeEW8=
github.com/Azure/go-autorest/tracing v0.6.0 h1:TYi4+3m5t6K48TGI9AUdb+IzbnSxvnvUMfuitfgcfuo=
github.com/Azure/go-autorest/tracing v0.6.0/go.mod h1:+vhtPC754Xsa23ID7GlGsrdKBpUA79WCAKPPZVC2DeU=
github.com/form3tech-oss/jwt-go v3.2.2+incompatible h1:TcekIExNqud5crz4xD2pavyTgWiPvpYe4Xau31I0PRk=
1 change: 1 addition & 0 deletions autorest/adal/sender.go
View file
Original file line number Diff line number Diff line change
@@ -28,6 +28,7 @@ const (
mimeTypeFormPost = "application/x-www-form-urlencoded"
)

// DO NOT ACCESS THIS DIRECTLY. go through sender()
var defaultSender Sender
var defaultSenderInit = &sync.Once{}

Loading