CustomScriptExtension fails for Windows VM

[asote]

Set commandToExecute as follows

settings = <<SETTINGS
    {
        "commandToExecute": "powershell Add-WindowsFeature Web-Server,Web-Asp-Net45,NET-Framework-Features"
    }
    SETTINGS

Fails with the following message:

• azurerm_virtual_machine_scale_set.vm-windows: compute.VirtualMachineScaleSetsClient#CreateOrUpdate: Failure sending request: StatusCode=200 -- Original Error: Long running operation terminated with status 'Failed': Code="VMExtensionProvisioningError" Message="VM has reported a failure when process
  ing extension 'vmssextension'. Error message: "Invalid handler configuration. Exiting. Error Message: Expecting state 'Element'.. Encountered 'Text'
  with name '', namespace ''. "."

[dtzar]

@asote Have you tried using a file or using powershell.exe versus powershell at the start?
"commandToExecute": "powershell.exe . . . -File './scripts/myscript.ps1'"
Please see futher documentation
Also - it's possible there is a problem with the current module using an outdated version 1.8 versus the current 1.9 Windows script extension. You can try out the code in this branch also which uses the latest script updates.
Please let us know if one of the above worked for you.

[asote]

Then the resource "azurerm_virtual_machine_scale_set" "vm-windows" needs to be modified. Currently it’s as follows: extension { name = "vmssextension" publisher = "Microsoft.Compute" type = "CustomScriptExtension" type_handler_version = "1.8" settings = <<SETTINGS { "commandToExecute": "${var.cmd_extension}" } SETTINGS It should be something like this: extension { name = "vmssextension" publisher = "Microsoft.Compute" type = "CustomScriptExtension" type_handler_version = "1.8" settings = <<SETTINGS { "fileUris": [ "https://raw.githubusercontent.com/Azure-Samples/compute-automation-configurations/master/automate-iis.ps1" ], "commandToExecute": "powershell -ExecutionPolicy Unrestricted -File automate-iis.ps1" } SETTINGS

[dtzar]

@asote Can you please try your original command with the latest code in my PR branch which uses the new version of the extension? I'd like to avoid modifying the module to utilize fileUris for now.

[dtzar]

I just verified that the commandToExecute by itself (as this module is today) works. I used this specifically, for example:
powershell Invoke-WebRequest -Uri https://downloads.puppetlabs.com/windows/puppet5/puppet-agent-5.5.1-x64.msi -OutFile C:/windows/temp/agent.msi
and I saw the agent.msi file present in the directory.

The fileUris is also a valid configuration / way to do this, but I view this as a new feature request to this module.