Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7.0.2
Choose a base ref
...
head repository: AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7.0.3
Choose a head ref

Commits on Sep 28, 2023

  1. Update changelog ahead of 7.0.2 release (#2338)

    Co-authored-by: Sruthi Keerthi Rangavajhula <srangavajhul@microsoft.com>
    sruke and Sruthi Keerthi Rangavajhula authored Sep 28, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    renovate-bot Mend Renovate
    Copy the full SHA
    9cd930c View commit details

Commits on Oct 2, 2023

  1. No need to check IsSupportedAlgorithm if getting from cache.

    Brent Schmaltz authored and brentschmaltz committed Oct 2, 2023
    Copy the full SHA
    e1b0c1f View commit details
  2. Copy the full SHA
    bdf36ce View commit details
  3. [Log Scrubbing] Clean up log messages in Wilson (#2339)

    * [Log Scrubbing] Clean up log messages in Wilson
    
    * Fix spelling nit and clarify collection use in comment
    
    * address PR feedback on spelling and input validation
    
    * addressing naming feedback
    TimHannMSFT authored Oct 2, 2023
    Copy the full SHA
    b0fadfe View commit details

Commits on Oct 6, 2023

  1. Added tests for public discovery endpoints.

    Brent Schmaltz authored and brentschmaltz committed Oct 6, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    37f3844 View commit details
  2. OpenIdConnectMessage serializers the same as 6x.

    Brent Schmaltz authored and brentschmaltz committed Oct 6, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c1a63dd View commit details
  3. Verified

    This commit was signed with the committer’s verified signature.
    renovate-bot Mend Renovate
    Copy the full SHA
    5cd6ed6 View commit details
  4. Added unit tets

    MoSelem authored and brentschmaltz committed Oct 6, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a5a4642 View commit details
  5. Copy the full SHA
    4c39291 View commit details
  6. Copy the full SHA
    dd1b458 View commit details
  7. re-adds flush

    gislikonrad authored and brentschmaltz committed Oct 6, 2023
    Copy the full SHA
    3cae455 View commit details

Commits on Oct 11, 2023

  1. Copy the full SHA
    d57eeb3 View commit details
  2. Remove dotnet.xunitextensions

    westin-m authored and brentschmaltz committed Oct 11, 2023
    Copy the full SHA
    ba1ec7f View commit details

Commits on Oct 12, 2023

  1. re-add preview tag (#2357)

    jennyf19 authored Oct 12, 2023
    Copy the full SHA
    5231862 View commit details

Commits on Oct 13, 2023

  1. Package version is set by scripts.

    Brent Schmaltz authored and brentschmaltz committed Oct 13, 2023
    Copy the full SHA
    fcc47b0 View commit details

Commits on Oct 16, 2023

  1. Copy the full SHA
    0134369 View commit details
  2. Update to next release. (#2359)

    Co-authored-by: Brent Schmaltz <brentsch@hotmail.com>
    brentschmaltz and Brent Schmaltz authored Oct 16, 2023
    Copy the full SHA
    cecd04e View commit details
  3. Copy the full SHA
    846c7b7 View commit details
  4. Copy the full SHA
    d92b8d1 View commit details
  5. Compatibility with 6x for bool claims (#2367)

    * Compatibility with 6x for bool claims
    
    Fix behavior where ToString is used on bool values
    resulting in the value being True/False instead of true/false
    
    * Use direct ClaimValueType
    
    ---------
    
    Co-authored-by: Keegan Caruso <keegancaruso@microsoft.com>
    keegan-caruso and Keegan Caruso authored Oct 16, 2023
    Copy the full SHA
    67ae82e View commit details

Commits on Oct 17, 2023

  1. 7.0.3 changelog (#2368)

    * 7.0.3 changelog
    
    * Update CHANGELOG.md
    
    Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
    
    ---------
    
    Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
    jennyf19 and jmprieur authored Oct 17, 2023
    Copy the full SHA
    68d8446 View commit details
  2. Update updateAssemblyInfo.ps1 (#2369)

    * Update updateAssemblyInfo.ps1
    
    * make release little r
    jennyf19 authored Oct 17, 2023
    Copy the full SHA
    bb354ce View commit details
Showing with 1,456 additions and 651 deletions.
  1. +49 −0 .github/ISSUE_TEMPLATE/design_proposal.md
  2. +11 −0 CHANGELOG.md
  3. +2 −1 benchmark/Microsoft.IdentityModel.Benchmarks/Microsoft.IdentityModel.Benchmarks.csproj
  4. +4 −29 build.ps1
  5. +0 −49 build/apiCompat.props
  6. +0 −224 build/apiCompat.ps1
  7. +5 −1 build/common.props
  8. +0 −4 build/commonTest.props
  9. +0 −1 build/dependenciesTest.props
  10. +1 −16 build/releaseBuild.yml
  11. +2 −2 buildConfiguration.xml
  12. +0 −70 generateContractAssemblies.ps1
  13. +9 −3 src/Microsoft.IdentityModel.JsonWebTokens/Json/JsonClaimSet.cs
  14. +12 −3 src/Microsoft.IdentityModel.JsonWebTokens/JsonWebToken.cs
  15. +5 −0 src/Microsoft.IdentityModel.Logging/IdentityModelEventSource.cs
  16. +47 −0 src/Microsoft.IdentityModel.Logging/LogHelper.cs
  17. +58 −11 src/Microsoft.IdentityModel.Logging/SecurityArtifact.cs
  18. +11 −1 src/Microsoft.IdentityModel.Protocols.OpenIdConnect/OpenIdConnectMessage.cs
  19. +5 −1 src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestHandler.cs
  20. +1 −0 src/Microsoft.IdentityModel.TestExtensions/Microsoft.IdentityModel.TestExtensions.csproj
  21. +3 −1 src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.cs
  22. +3 −1 src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.cs
  23. +15 −9 src/Microsoft.IdentityModel.Tokens/CryptoProviderFactory.cs
  24. +9 −2 src/Microsoft.IdentityModel.Tokens/Validators.cs
  25. +4 −1 src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs
  26. +17 −0 src/Microsoft.IdentityModel.Xml/DelegatingXmlDictionaryReader.cs
  27. +202 −90 src/Microsoft.IdentityModel.Xml/DsigSerializer.cs
  28. +10 −8 src/Microsoft.IdentityModel.Xml/Reference.cs
  29. +15 −0 src/System.IdentityModel.Tokens.Jwt/JwtPayload.cs
  30. +1 −0 ...rosoft.IdentityModel.AotCompatibility.Tests/Microsoft.IdentityModel.AotCompatibility.Tests.csproj
  31. +23 −18 test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandlerTests.cs
  32. +29 −1 test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenTests.cs
  33. +36 −9 test/Microsoft.IdentityModel.JsonWebTokens.Tests/JwtTokenUtilitiesTests.cs
  34. +456 −0 test/Microsoft.IdentityModel.Logging.Tests/LogHelperTests.cs
  35. +72 −7 test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTests.cs
  36. +3 −0 test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/OpenIdConfigData.cs
  37. +0 −2 ...Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/OpenIdConnectConfigurationRetrieverTests.cs
  38. +93 −22 test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/OpenIdConnectMessageTests.cs
  39. +25 −0 test/Microsoft.IdentityModel.TestUtils/Default.cs
  40. +6 −0 test/Microsoft.IdentityModel.TestUtils/ExpectedException.cs
  41. +12 −0 test/Microsoft.IdentityModel.TestUtils/XmlUtilities.cs
  42. +18 −20 test/Microsoft.IdentityModel.Tokens.Tests/AuthenticatedEncryptionProviderTests.cs
  43. +14 −9 test/Microsoft.IdentityModel.Tokens.Tests/ReferenceTests.cs
  44. +23 −25 test/Microsoft.IdentityModel.Tokens.Tests/SignatureProviderTests.cs
  45. +22 −0 test/Microsoft.IdentityModel.Validators.Tests/MicrosoftIdentityIssuerValidatorTest.cs
  46. +3 −3 test/Microsoft.IdentityModel.Validators.Tests/ValidatorConstants.cs
  47. +69 −0 test/Microsoft.IdentityModel.Xml.Tests/DelegatingXmlDictionaryReaderTests.cs
  48. +21 −0 test/Microsoft.IdentityModel.Xml.Tests/ReferenceTests.cs
  49. +4 −4 test/System.IdentityModel.Tokens.Jwt.Tests/JwtPayloadTest.cs
  50. +25 −0 test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenTests.cs
  51. +1 −3 updateAssemblyInfo.ps1
49 changes: 49 additions & 0 deletions .github/ISSUE_TEMPLATE/design_proposal.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
---
name: 🤔 Design proposal
about: Collaborate on a design for a feature/fix or other change
labels: design-proposal
---

<!--
This template is useful to build consensus about whether work should be done, and if so, the high-level shape of how it should be approached. Use this before fixating on a particular implementation.
-->

## Summary

1-2 sentences. Say what this is about.

## Motivation and goals

1-2 paragraphs, or a bullet-pointed list. What existing pain points does this solve? What evidence shows it's valuable to solve this?

## In scope

A list of major scenarios, perhaps in priority order.

## Out of scope

Scenarios you explicitly want to exclude.

## Risks / unknowns

How might developers misinterpret/misuse this? How might implementing it restrict us from other enhancements in the future? Also list any perf/security/correctness concerns.

## Examples

Give brief examples of possible developer experiences (e.g., code they would write).

Don't be deeply concerned with how it would be implemented yet. Your examples could even be from other technology stacks.

<!--
# Detailed design
It's often best not to fill this out until you get basic consensus about the above. When you do, consider adding an implementation proposal with the following headings:
Detailed design
Drawbacks
Considered alternatives
Open questions
References
If there's one clear design you have consensus on, you could do that directly in a PR.
-->
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
See the [releases](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases) for details on bug fixes and added features.

7.0.3
======
### Bug Fixes:
- Fix errors like the following reported by multiple customers at dotnet/aspnetcore#51005 when they tried to upgrade their app using `AddMicrosoftIdentityWebApp` to .NET 8. See [PR](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2361) for details.
- Fix compatibility issue with 6x when claims are a bool. See issue [#2354](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/2354) for details.

7.0.2
======
### Bug Fixes:
- Resolved an issue where JsonWebToken properties would throw exceptions when the input string was 'null'. See PR[#2335](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2335) for details.

7.0.1
======
### Bug Fixes:
Original file line number Diff line number Diff line change
@@ -4,7 +4,8 @@
<AssemblyName>Microsoft.IdentityModel.Benchmarks</AssemblyName>
<PackageId>Microsoft.IdentityModel.Benchmarks</PackageId>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFrameworks Condition="'$(TargetNet8)' == 'True'">net6.0; net8.0</TargetFrameworks>
<TargetFrameworks Condition="'$(TargetNet8)' != 'True'">net6.0</TargetFrameworks>
<SignAssembly>True</SignAssembly>
<DelaySign>True</DelaySign>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)..\..\build\35MSSharedLib1024.snk</AssemblyOriginatorKeyFile>
33 changes: 4 additions & 29 deletions build.ps1
Original file line number Diff line number Diff line change
@@ -5,9 +5,8 @@ param(
[string]$root=$PSScriptRoot,
[string]$runTests="YES",
[string]$failBuildOnTest="YES",
[string]$slnFile="wilson.sln",
[switch]$runApiCompat,
[switch]$generateContractAssemblies)
[string]$slnFile="wilson.sln"
)

################################################# Functions ############################################################

@@ -47,21 +46,6 @@ function CreateArtifactsRoot($folder)
mkdir $folder | Out-Null
}

function GenerateContractAssemblies($root)
{
# clear content of baseline files as it is not relevant for the next version
ClearBaselineFiles($root)

# execute generateContractAssemblies script
& "$root\generateContractAssemblies.ps1".
}

function ClearBaselineFiles($root)
{
Write-Host ">>> Clear-Content $root\Tools\apiCompat\baseline\*.txt"
Clear-Content $root\Tools\apiCompat\baseline\*.txt
}

################################################# Functions ############################################################

if ($env:VSINSTALLDIR)
@@ -79,8 +63,6 @@ Write-Host "root: " $root;
Write-Host "runTests: " $runTests;
Write-Host "failBuildOnTest: " $failBuildOnTest;
Write-Host "slnFile: " $slnFile;
Write-Host "runApiCompat: " $runApiCompat;
Write-Host "generateContractAssemblies: " $generateContractAssemblies;
WriteSectionFooter("End build.ps1 - parameters");

[xml]$buildConfiguration = Get-Content $PSScriptRoot\buildConfiguration.xml
@@ -138,24 +120,17 @@ CreateArtifactsRoot($artifactsRoot);
pushd
Set-Location $root
Write-Host ""
Write-Host ">>> Start-Process -wait -NoNewWindow $msbuildexe /restore:True /p:UseSharedCompilation=false /nr:false /verbosity:m /p:Configuration=$buildType /p:RunApiCompat=$runApiCompat $slnFile"
Write-Host ">>> Start-Process -wait -NoNewWindow $msbuildexe /restore:True /p:UseSharedCompilation=false /nr:false /verbosity:m /p:Configuration=$buildType $slnFile"
Write-Host ""
Write-Host "msbuildexe: " $msbuildexe
$p = Start-Process -Wait -PassThru -NoNewWindow $msbuildexe "/r:True /p:UseSharedCompilation=false /nr:false /verbosity:m /p:Configuration=$buildType /p:RunApiCompat=$runApiCompat $slnFile"
$p = Start-Process -Wait -PassThru -NoNewWindow $msbuildexe "/r:True /p:UseSharedCompilation=false /nr:false /verbosity:m /p:Configuration=$buildType $slnFile"

if($p.ExitCode -ne 0)
{
throw "Build failed."
}
popd

if ($generateContractAssemblies.IsPresent)
{
WriteSectionHeader("Generating Contract Assemblies");
GenerateContractAssemblies($root);
WriteSectionFooter("End Generating Contract Assemblies");
}

foreach($project in $buildConfiguration.SelectNodes("root/projects/src/project"))
{
$name = $project.name;
49 changes: 0 additions & 49 deletions build/apiCompat.props

This file was deleted.

Loading