From 808bf81d9dd2505ba7b27e2282f5134296dcde59 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Mon, 5 Dec 2022 10:51:12 -0800 Subject: [PATCH] chore: bump Playwright to 1.28 --- .../ElectronPlaywrightTestUtils.ts | 2 +- .../ElectronTestApp/package.json | 3 +- .../test/electron-code-aad.spec.ts | 3 +- .../test/electron-code-adfs.spec.ts | 3 +- samples/package-lock.json | 39 ++++--------------- samples/package.json | 2 +- 6 files changed, 12 insertions(+), 40 deletions(-) diff --git a/samples/e2eTestUtils/ElectronPlaywrightTestUtils.ts b/samples/e2eTestUtils/ElectronPlaywrightTestUtils.ts index 755ab09032..a18dd07595 100644 --- a/samples/e2eTestUtils/ElectronPlaywrightTestUtils.ts +++ b/samples/e2eTestUtils/ElectronPlaywrightTestUtils.ts @@ -1,4 +1,4 @@ -import { ElectronApplication, Page } from "playwright"; +import { ElectronApplication, Page } from "playwright-core"; import * as fs from "fs"; export async function enterCredentials(page: Page, screenshot: Screenshot, username: string, accountPwd: string): Promise { diff --git a/samples/msal-node-samples/ElectronTestApp/package.json b/samples/msal-node-samples/ElectronTestApp/package.json index f6c06f38a2..e0179f0ba6 100644 --- a/samples/msal-node-samples/ElectronTestApp/package.json +++ b/samples/msal-node-samples/ElectronTestApp/package.json @@ -20,10 +20,9 @@ "author": "", "license": "MIT", "devDependencies": { - "@playwright/test": "~1.27.0", + "@playwright/test": "~1.28.1", "babel": "^6.23.0", "electron": "^18.0.1", - "playwright": "~1.27.0", "typescript": "^4.1.2" }, "dependencies": { diff --git a/samples/msal-node-samples/ElectronTestApp/test/electron-code-aad.spec.ts b/samples/msal-node-samples/ElectronTestApp/test/electron-code-aad.spec.ts index bfddcf846c..eaed113783 100644 --- a/samples/msal-node-samples/ElectronTestApp/test/electron-code-aad.spec.ts +++ b/samples/msal-node-samples/ElectronTestApp/test/electron-code-aad.spec.ts @@ -1,7 +1,6 @@ import * as path from 'path'; -import { ElectronApplication, Page, _electron as electron } from "playwright"; -import { test, expect, } from "@playwright/test"; +import { ElectronApplication, Page, _electron as electron, test, expect } from "@playwright/test"; import { setupCredentials } from "../../../e2eTestUtils/TestUtils"; import { NodeCacheTestUtils } from "../../../e2eTestUtils/NodeCacheTestUtils"; diff --git a/samples/msal-node-samples/ElectronTestApp/test/electron-code-adfs.spec.ts b/samples/msal-node-samples/ElectronTestApp/test/electron-code-adfs.spec.ts index 47277515bc..c378a92ff4 100644 --- a/samples/msal-node-samples/ElectronTestApp/test/electron-code-adfs.spec.ts +++ b/samples/msal-node-samples/ElectronTestApp/test/electron-code-adfs.spec.ts @@ -1,7 +1,6 @@ import * as path from 'path'; -import { ElectronApplication, Page, _electron as electron } from "playwright"; -import { test, expect, } from "@playwright/test"; +import { ElectronApplication, Page, _electron as electron, test, expect } from "@playwright/test"; import { setupCredentials } from "../../../e2eTestUtils/TestUtils"; import { NodeCacheTestUtils } from "../../../e2eTestUtils/NodeCacheTestUtils"; diff --git a/samples/package-lock.json b/samples/package-lock.json index ece627474a..79f71d1471 100644 --- a/samples/package-lock.json +++ b/samples/package-lock.json @@ -19,7 +19,7 @@ "dotenv": "^8.2.0", "find-process": "^1.4.4", "jest": "^27.1.1", - "playwright": "~1.27.0", + "playwright-core": "~1.28.1", "puppeteer": "^19.2.0", "ts-jest": "^27.0.5" } @@ -4580,26 +4580,10 @@ "node": ">=8" } }, - "node_modules/playwright": { - "version": "1.27.1", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.27.1.tgz", - "integrity": "sha512-xXYZ7m36yTtC+oFgqH0eTgullGztKSRMb4yuwLPl8IYSmgBM88QiB+3IWb1mRIC9/NNwcgbG0RwtFlg+EAFQHQ==", - "dev": true, - "hasInstallScript": true, - "dependencies": { - "playwright-core": "1.27.1" - }, - "bin": { - "playwright": "cli.js" - }, - "engines": { - "node": ">=14" - } - }, "node_modules/playwright-core": { - "version": "1.27.1", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.27.1.tgz", - "integrity": "sha512-9EmeXDncC2Pmp/z+teoVYlvmPWUC6ejSSYZUln7YaP89Z6lpAaiaAnqroUt/BoLo8tn7WYShcfaCh+xofZa44Q==", + "version": "1.28.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.28.1.tgz", + "integrity": "sha512-3PixLnGPno0E8rSBJjtwqTwJe3Yw72QwBBBxNoukIj3lEeBNXwbNiKrNuB1oyQgTBw5QHUhNO3SteEtHaMK6ag==", "dev": true, "bin": { "playwright": "cli.js" @@ -9474,19 +9458,10 @@ "find-up": "^4.0.0" } }, - "playwright": { - "version": "1.27.1", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.27.1.tgz", - "integrity": "sha512-xXYZ7m36yTtC+oFgqH0eTgullGztKSRMb4yuwLPl8IYSmgBM88QiB+3IWb1mRIC9/NNwcgbG0RwtFlg+EAFQHQ==", - "dev": true, - "requires": { - "playwright-core": "1.27.1" - } - }, "playwright-core": { - "version": "1.27.1", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.27.1.tgz", - "integrity": "sha512-9EmeXDncC2Pmp/z+teoVYlvmPWUC6ejSSYZUln7YaP89Z6lpAaiaAnqroUt/BoLo8tn7WYShcfaCh+xofZa44Q==", + "version": "1.28.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.28.1.tgz", + "integrity": "sha512-3PixLnGPno0E8rSBJjtwqTwJe3Yw72QwBBBxNoukIj3lEeBNXwbNiKrNuB1oyQgTBw5QHUhNO3SteEtHaMK6ag==", "dev": true }, "prebuild-install": { diff --git a/samples/package.json b/samples/package.json index c0eca7ad3c..72ea778e05 100644 --- a/samples/package.json +++ b/samples/package.json @@ -18,7 +18,7 @@ "dotenv": "^8.2.0", "find-process": "^1.4.4", "jest": "^27.1.1", - "playwright": "~1.27.0", + "playwright-core": "~1.28.1", "puppeteer": "^19.2.0", "ts-jest": "^27.0.5" }