Adding support for Microsoft.NET.Sdk.Worker #2645
Conversation
|
|
||
| builder.Services.AddHostedService<Worker>(); | ||
|
|
||
| builder.Services.AddTokenAcquisition(isTokenAcquisitionSingleton:true) |
There was a problem hiding this comment.
We could introduce a:
TokenAcquirerFactory.GetDefault(hostBuilder) adds the token acquisition, the cache and sets the MicrosoftIdentityOptions.
Note that the AddTokenAcquisition in this case uses an Sdk host, which means it's not drawing ASP.NET Core services.
| private readonly ILogger<Worker> _logger; | ||
| private readonly IDownstreamApi _downstreamApi; | ||
|
|
||
| public Worker(ILogger<Worker> logger, IDownstreamApi downstreamApi) |
There was a problem hiding this comment.
Just inject the IDownstreamApi or GraphServiceClient etc ...
| if (_logger.IsEnabled(LogLevel.Information)) | ||
| { | ||
| _logger.LogInformation("Worker running at: {time}", DateTimeOffset.Now); | ||
| var result = await _downstreamApi.CallApiAsync("MyWebApi"); |
| }, | ||
|
|
||
| "MyWebApi": { | ||
| "BaseUrl": "https://graph.microsoft.com/v1.0", |
There was a problem hiding this comment.
Used Microsoft Graph as a well-known service in this sample.
| return services; | ||
| } | ||
|
|
||
| private static void RegisterDownstreamApi(IServiceCollection services) |
There was a problem hiding this comment.
Is it not possible to unit test this? Seems like you just need to register a few mock ITokenAcquisition / IDownstream APIs with different lifetimes, get them from the service collection and assert on their lifetime.
…icrosoft-identity-web into jmprieur/supportWorker
- Adding the configuration code generator and removing the trimming warning that is no longer needed - Fixing OWIN Web.config
are using the code generators
Adding support for Microsoft.NET.Sdk.Worker
This PR:
Fixes:
Related to:
cc: @DavidParks8, @jennyf19