fix: adjust report location for no-operation-name-suffix rule (#721)

dimaMachina · Oct 27, 2021 · 98b6bcb · 98b6bcb
1 parent eb4a851
commit 98b6bcb
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/.changeset/heavy-chicken-dream.md b/.changeset/heavy-chicken-dream.md
@@ -0,0 +1,5 @@
+---
+'@graphql-eslint/eslint-plugin': patch
+---
+
+fix: adjust report location for `no-operation-name-suffix` rule
diff --git a/packages/plugin/src/rules/no-operation-name-suffix.ts b/packages/plugin/src/rules/no-operation-name-suffix.ts
@@ -42,12 +42,23 @@ const rule: GraphQLESLintRule = {
       'OperationDefinition, FragmentDefinition'(
         node: GraphQLESTreeNode<OperationDefinitionNode | FragmentDefinitionNode>
       ) {
-        if (node && node.name && node.name.value !== '') {
-          const invalidSuffix = (node.type === 'OperationDefinition' ? node.operation : 'fragment').toLowerCase();
+        const name = node.name?.value || '';
+        if (name.length > 0) {
+          const invalidSuffix = 'operation' in node ? node.operation : 'fragment';
 
-          if (node.name.value.toLowerCase().endsWith(invalidSuffix)) {
+          if (name.toLowerCase().endsWith(invalidSuffix)) {
+            const { start, end } = node.name.loc;
             context.report({
-              node: node.name,
+              loc: {
+                start: {
+                  column: start.column - 1 + name.length - invalidSuffix.length,
+                  line: start.line,
+                },
+                end: {
+                  column: end.column - 1 + name.length,
+                  line: end.line,
+                },
+              },
               data: {
                 invalidSuffix,
               },